Subject: Re: [PATCH net-next 1/3] bnxt_en: refactor VNIC RSS update functions

From: Leon Romanovsky <[email-masked]>
Date: Mon, 7 Nov 2022 09:51:22 +0200

On Sun, Nov 06, 2022 at 07:16:30PM -0500, Michael Chan wrote:
> From: Edwin Peer <[email-masked]>
> 
> Extract common code into a new function. This will avoid duplication
> in the next patch, which changes the update algorithm for both the P5
> and legacy code paths.
> 
> No functional changes.
> 
> Signed-off-by: Edwin Peer <[email-masked]>
> Signed-off-by: Michael Chan <[email-masked]>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 +++++++++++------------
>  1 file changed, 16 insertions(+), 18 deletions(-)

<...>

> +static void
> +__bnxt_hwrm_vnic_set_rss(struct bnxt *bp, struct hwrm_vnic_rss_cfg_input *req,
> +			 struct bnxt_vnic_info *vnic)

The "__" prefix in __func_name() usually means in kernel that this function
is locked externally.

Thanks,
Reviewed-by: Leon Romanovsky <[email-masked]>