From: Leon Romanovsky <leon@kernel•org>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, kuba@kernel•org,
edumazet@google•com, pabeni@redhat•com, gospo@broadcom•com,
pavan.chebbi@broadcom•com
Subject: Re: [PATCH net-next 2/3] bnxt_en: update RSS config using difference algorithm
Date: Mon, 7 Nov 2022 09:51:41 +0200 [thread overview]
Message-ID: <Y2i5DfPo0nmPg2iK@unreal> (raw)
In-Reply-To: <1667780192-3700-3-git-send-email-michael.chan@broadcom.com>
On Sun, Nov 06, 2022 at 07:16:31PM -0500, Michael Chan wrote:
> From: Edwin Peer <edwin.peer@broadcom•com>
>
> Hardware is unable to realize all legal firmware interface state values
> for hash_type. For example, if 4-tuple TCP_IPV4 hash is enabled,
> 4-tuple UDP_IPV4 hash must also be enabled. By providing the bits the
> user intended to change instead of the possible illegal intermediate
> states, the firmware is able to make better compromises when deciding
> which bits to ignore.
>
> With this new mechansim, we can now report the actual configured hash
> back to the user. Add bnxt_hwrm_update_rss_hash_cfg() to report the
> actual hash after user configuration.
>
> Signed-off-by: Edwin Peer <edwin.peer@broadcom•com>
> Signed-off-by: Michael Chan <michael.chan@broadcom•com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 35 +++++++++++++-
> drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +
> .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +
> drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 47 +++++++++++++++++++
> 4 files changed, 85 insertions(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia•com>
next prev parent reply other threads:[~2022-11-07 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 0:16 [PATCH net-next 0/3] bnxt_en: Updates Michael Chan
2022-11-07 0:16 ` [PATCH net-next 1/3] bnxt_en: refactor VNIC RSS update functions Michael Chan
2022-11-07 7:51 ` Leon Romanovsky
2022-11-07 0:16 ` [PATCH net-next 2/3] bnxt_en: update RSS config using difference algorithm Michael Chan
2022-11-07 7:51 ` Leon Romanovsky [this message]
2022-11-07 0:16 ` [PATCH net-next 3/3] bnxt_en: Add a non-real time mode to access NIC clock Michael Chan
2022-11-07 7:51 ` Leon Romanovsky
2022-11-08 11:50 ` [PATCH net-next 0/3] bnxt_en: Updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2i5DfPo0nmPg2iK@unreal \
--to=leon@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox