From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH v1 1/1] mac_pton: Don't access memory over expected length
Date: Tue, 8 Nov 2022 15:55:06 +0200 [thread overview]
Message-ID: <Y2pfuloLUBKZ1+IA@smile.fi.intel.com> (raw)
In-Reply-To: <Y0SEfZi9oewmefGK@lunn.ch>
On Mon, Oct 10, 2022 at 10:45:49PM +0200, Andrew Lunn wrote:
> On Mon, Oct 10, 2022 at 11:29:37PM +0300, Andy Shevchenko wrote:
> > On Mon, Oct 10, 2022 at 10:19:49PM +0200, Andrew Lunn wrote:
> > > On Wed, Oct 05, 2022 at 07:43:01PM +0300, Andy Shevchenko wrote:
> > > > The strlen() may go too far when estimating the length of
> > > > the given string. In some cases it may go over the boundary
> > > > and crash the system which is the case according to the commit
> > > > 13a55372b64e ("ARM: orion5x: Revert commit 4904dbda41c8.").
> > > >
> > > > Rectify this by switching to strnlen() for the expected
> > > > maximum length of the string.
> > >
> > > This seems like something which should have a fixes: tag, and be
> > > against net, not net-next.
> >
> > I can (re-)send it that way. Just need a consensus by net maintainers.
>
> I would probably do:
>
> if (strnlen(s, maxlen) != maxlen)
> return false;
>
> I doubt anybody is removing leading zeros in MAC addresses.
I'm not sure what this change gives us. < maxlen is more readable to understand
that we refuse anything that less than maxlen, with your change it's easy to
misinterpret it (by missing 'n' in the non-standard call) as "it must equal to
maxlen" which is obviously not true.
That said, I leave it as is.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-08 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 16:43 [PATCH v1 1/1] mac_pton: Don't access memory over expected length Andy Shevchenko
2022-10-06 3:37 ` Jakub Kicinski
2022-10-10 20:19 ` Andrew Lunn
2022-10-10 20:29 ` Andy Shevchenko
2022-10-10 20:45 ` Andrew Lunn
2022-11-08 13:55 ` Andy Shevchenko [this message]
2022-10-11 0:38 ` Jakub Kicinski
2022-11-08 13:51 ` Andy Shevchenko
2022-11-08 13:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2pfuloLUBKZ1+IA@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox