From: Andrew Lunn <andrew@lunn•ch>
To: David Thompson <davthompson@nvidia•com>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, netdev@vger•kernel.org, cai.huoqing@linux•dev,
brgl@bgdev•pl, limings@nvidia•com, chenhao288@hisilicon•com,
huangguangbin2@huawei•com, Asmaa Mnebhi <asmaa@nvidia•com>
Subject: Re: [PATCH net-next v2 4/4] mlxbf_gige: add "set_link_ksettings" ethtool callback
Date: Thu, 10 Nov 2022 14:26:10 +0100 [thread overview]
Message-ID: <Y2z78lwaeJKnL6DJ@lunn.ch> (raw)
In-Reply-To: <20221109224752.17664-5-davthompson@nvidia.com>
On Wed, Nov 09, 2022 at 05:47:52PM -0500, David Thompson wrote:
> This patch extends the "ethtool_ops" data structure to
> include the "set_link_ksettings" callback. This change
> enables configuration of the various interface speeds
> that the BlueField-3 supports (10Mbps, 100Mbps, and 1Gbps).
>
> Signed-off-by: David Thompson <davthompson@nvidia•com>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia•com>
> ---
> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c | 1 +
> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c
> index 41ebef25a930..253d7ad9b809 100644
> --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c
> @@ -135,4 +135,5 @@ const struct ethtool_ops mlxbf_gige_ethtool_ops = {
> .nway_reset = phy_ethtool_nway_reset,
> .get_pauseparam = mlxbf_gige_get_pauseparam,
> .get_link_ksettings = phy_ethtool_get_link_ksettings,
> + .set_link_ksettings = phy_ethtool_set_link_ksettings,
> };
> diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> index 80060a54ba95..a9fa662e0665 100644
> --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> @@ -224,7 +224,7 @@ static int mlxbf_gige_stop(struct net_device *netdev)
> }
>
> static int mlxbf_gige_eth_ioctl(struct net_device *netdev,
> - struct ifreq *ifr, int cmd)
> + struct ifreq *ifr, int cmd)
> {
> if (!(netif_running(netdev)))
> return -EINVAL;
White space changes should be in a separate patch.
With this fixed:
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
prev parent reply other threads:[~2022-11-10 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 22:47 [PATCH net-next v2 0/4] mlxbf_gige: add BlueField-3 support David Thompson
2022-11-09 22:47 ` [PATCH net-next v2 1/4] mlxbf_gige: add MDIO support for BlueField-3 David Thompson
2022-11-10 13:24 ` Andrew Lunn
2022-11-09 22:47 ` [PATCH net-next v2 2/4] mlxbf_gige: support 10M/100M/1G speeds on BlueField-3 David Thompson
2022-11-10 13:23 ` Andrew Lunn
2022-11-09 22:47 ` [PATCH net-next v2 3/4] mlxbf_gige: add BlueField-3 Serdes configuration David Thompson
2022-11-10 13:33 ` Andrew Lunn
2022-11-12 5:34 ` Jakub Kicinski
2022-11-12 9:52 ` Saeed Mahameed
2022-11-12 15:53 ` Andrew Lunn
2022-11-15 0:56 ` Jakub Kicinski
2022-11-15 0:50 ` Jakub Kicinski
2022-11-15 1:06 ` Andrew Lunn
2022-11-15 1:13 ` Jakub Kicinski
2022-11-16 16:30 ` Jakub Kicinski
2022-11-17 2:01 ` Saeed Mahameed
2022-11-17 6:23 ` Jakub Kicinski
2022-11-09 22:47 ` [PATCH net-next v2 4/4] mlxbf_gige: add "set_link_ksettings" ethtool callback David Thompson
2022-11-10 13:26 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2z78lwaeJKnL6DJ@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=asmaa@nvidia$(echo .)com \
--cc=brgl@bgdev$(echo .)pl \
--cc=cai.huoqing@linux$(echo .)dev \
--cc=chenhao288@hisilicon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=davthompson@nvidia$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=huangguangbin2@huawei$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=limings@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox