From: Al Viro <viro@zeniv•linux.org.uk>
To: asmadeus@codewreck•org
Cc: Wang Hai <wanghai38@huawei•com>,
ericvh@gmail•com, lucho@ionkov•net, linux_oss@crudebyte•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, v9fs-developer@lists•sourceforge.net,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH net] net/9p: Fix a potential socket leak in p9_socket_open
Date: Thu, 24 Nov 2022 16:15:37 +0000 [thread overview]
Message-ID: <Y3+YqUbLXZ1ouynB@ZenIV> (raw)
In-Reply-To: <Y382Spkkzt+i86e8@codewreck.org>
On Thu, Nov 24, 2022 at 06:15:54PM +0900, asmadeus@codewreck•org wrote:
> Wang Hai wrote on Thu, Nov 24, 2022 at 04:10:05PM +0800:
> > Both p9_fd_create_tcp() and p9_fd_create_unix() will call
> > p9_socket_open(). If the creation of p9_trans_fd fails,
> > p9_fd_create_tcp() and p9_fd_create_unix() will return an
> > error directly instead of releasing the cscoket, which will
>
> (typo, socket or csocket -- I'll fix this on applying)
>
> > result in a socket leak.
> >
> > This patch adds sock_release() to fix the leak issue.
>
> Thanks, it looks good to me.
> A bit confusing that sock_alloc_files() calls sock_release() itself on
> failure, but that means this one's safe at least...
sock_alloc_file() unconditionally consumes socket reference;
either it is transferred to new struct file it returns, or
it's dropped. Makes for simpler logics in callers...
FWIW,
ACKed-by: Al Viro <viro@zeniv•linux.org.uk>
on the leak fix.
next prev parent reply other threads:[~2022-11-24 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 8:10 [PATCH net] net/9p: Fix a potential socket leak in p9_socket_open Wang Hai
2022-11-24 9:15 ` asmadeus
2022-11-24 11:19 ` wanghai (M)
2022-11-24 16:15 ` Al Viro [this message]
2022-11-28 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3+YqUbLXZ1ouynB@ZenIV \
--to=viro@zeniv$(echo .)linux.org.uk \
--cc=asmadeus@codewreck$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=ericvh@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux_oss@crudebyte$(echo .)com \
--cc=lucho@ionkov$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=v9fs-developer@lists$(echo .)sourceforge.net \
--cc=wanghai38@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox