Subject: Re: [net 04/14] net/mlx5: cmdif, Print info on any firmware cmd failure to tracepoint

From: Maciej Fijalkowski <[email-masked]>
Date: Wed, 23 Nov 2022 16:06:59 +0100

On Mon, Nov 21, 2022 at 06:25:49PM -0800, Saeed Mahameed wrote:
> From: Moshe Shemesh <[email-masked]>
> 
> While moving to new CMD API (quiet API), some pre-existing flows may call the new API
> function that in case of error, returns the error instead of printing it as previously done.
> For such flows we bring back the print but to tracepoint this time for sys admins to
> have the ability to check for errors especially for commands using the new quiet API.
> 

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars
per line)

> Tracepoint output example:
>          devlink-1333    [001] .....   822.746922: mlx5_cmd: ACCESS_REG(0x805) op_mod(0x0) failed, status bad resource(0x5), syndrome (0xb06e1f), err(-22)
> 
> Fixes: f23519e542e5 ("net/mlx5: cmdif, Add new api for command execution")
> Signed-off-by: Moshe Shemesh <[email-masked]>
> Reviewed-by: Shay Drory <[email-masked]>
> Reviewed-by: Maor Gottlieb <[email-masked]>
> Signed-off-by: Saeed Mahameed <[email-masked]>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 41 +++++++++--------
>  .../mellanox/mlx5/core/diag/cmd_tracepoint.h  | 45 +++++++++++++++++++
>  include/linux/mlx5/driver.h                   |  1 +
>  3 files changed, 68 insertions(+), 19 deletions(-)
>  create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/diag/cmd_tracepoint.h