From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Liu Jian <liujian56@huawei•com>
Cc: chris.snook@gmail•com, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, linux@rempel-privat•de,
netdev@vger•kernel.org
Subject: Re: [PATCH] net: ag71xx: call phylink_disconnect_phy if ag71xx_hw_enable() fail in ag71xx_open()
Date: Mon, 14 Nov 2022 10:49:10 +0000 [thread overview]
Message-ID: <Y3IdJjCYb/L+ph9D@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221114095549.40342-1-liujian56@huawei.com>
On Mon, Nov 14, 2022 at 05:55:49PM +0800, Liu Jian wrote:
> If ag71xx_hw_enable() fails, call phylink_disconnect_phy() to clean up.
> And if phylink_of_phy_connect() fails, nothing needs to be done.
> Compile tested only.
>
> Fixes: 892e09153fa3 ("net: ag71xx: port to phylink")
> Signed-off-by: Liu Jian <liujian56@huawei•com>
LGTM.
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-11-14 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:55 [PATCH] net: ag71xx: call phylink_disconnect_phy if ag71xx_hw_enable() fail in ag71xx_open() Liu Jian
2022-11-14 10:49 ` Russell King (Oracle) [this message]
2022-11-16 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3IdJjCYb/L+ph9D@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=chris.snook@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@rempel-privat$(echo .)de \
--cc=liujian56@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox