From: Andrew Lunn <andrew@lunn•ch>
To: Jiawen Wu <jiawenwu@trustnetic•com>
Cc: 'Mengyuan Lou' <mengyuanlou@net-swift•com>, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/5] net: txgbe: Identify PHY and SFP module
Date: Mon, 14 Nov 2022 14:25:47 +0100 [thread overview]
Message-ID: <Y3JB2xrBOOa6MR+H@lunn.ch> (raw)
In-Reply-To: <005c01d8f80c$574c16d0$05e44470$@trustnetic.com>
> When ethernet driver does a reset to the hardware, like
> 'txgbe_reset_hw', the I2C configuration will be reset. It needs to
> be reconfigured once. So how could I call the I2C function here? Can
> I treat the I2C driver as a lib?
The I2C driver will be embedded within your MAC driver. So you have
control over it.
How often do you need to call txgbe_reset_hw()? Hopefully just once
early in the probe? So you can register the I2C bus master with the
I2C core after the reset.
If you need to use txgbe_reset_hw() at other times, you will need a
mutex or similar in .master_xfer function so you don't perform a reset
while an I2C transfer is happening, or start another transfer while a
reset is happening.
Andrew
next prev parent reply other threads:[~2022-11-14 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:19 [PATCH net-next 0/5] net: WangXun ethernet drivers Mengyuan Lou
2022-11-08 11:19 ` [PATCH net-next 1/5] net: txgbe: Identify PHY and SFP module Mengyuan Lou
2022-11-08 20:52 ` Andrew Lunn
2022-11-09 6:32 ` Jiawen Wu
2022-11-09 13:26 ` Andrew Lunn
2022-11-14 9:34 ` Jiawen Wu
2022-11-14 13:25 ` Andrew Lunn [this message]
2022-11-29 8:20 ` Jiawen Wu
2022-11-14 15:34 ` Alexander Lobakin
2022-11-14 20:18 ` Andrew Lunn
2022-11-08 11:19 ` [PATCH net-next 2/5] net: txgbe: Initialize service task Mengyuan Lou
2022-11-08 23:55 ` Jakub Kicinski
2022-11-09 2:16 ` Jiawen Wu
2022-11-09 2:36 ` Andrew Lunn
2022-11-14 15:39 ` Alexander Lobakin
2022-11-08 11:19 ` [PATCH net-next 3/5] net: txgbe: Support to setup link Mengyuan Lou
2022-11-08 21:03 ` Andrew Lunn
2022-11-14 15:48 ` Alexander Lobakin
2022-11-14 20:20 ` Andrew Lunn
2022-11-08 11:19 ` [PATCH net-next 4/5] net: ngbe: Initialize phy information Mengyuan Lou
2022-11-08 21:10 ` Andrew Lunn
2022-11-11 3:13 ` mengyuanlou
2022-11-11 3:28 ` Andrew Lunn
2022-11-14 16:16 ` Alexander Lobakin
2022-11-08 11:19 ` [PATCH net-next 5/5] net: ngbe: Initialize service task Mengyuan Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3JB2xrBOOa6MR+H@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox