From: Andrew Lunn <andrew@lunn•ch>
To: Alexander Lobakin <alexandr.lobakin@intel•com>
Cc: Mengyuan Lou <mengyuanlou@net-swift•com>,
netdev@vger•kernel.org, jiawenwu@trustnetic•com
Subject: Re: [PATCH net-next 3/5] net: txgbe: Support to setup link
Date: Mon, 14 Nov 2022 21:20:36 +0100 [thread overview]
Message-ID: <Y3KjFLibpFlws1N5@lunn.ch> (raw)
In-Reply-To: <20221114154824.704046-1-alexandr.lobakin@intel.com>
On Mon, Nov 14, 2022 at 04:48:24PM +0100, Alexander Lobakin wrote:
> From: Mengyuan Lou <mengyuanlou@net-swift•com>
> Date: Tue, 8 Nov 2022 19:19:05 +0800
>
> > From: Jiawen Wu <jiawenwu@trustnetic•com>
> >
> > Get link capabilities, setup MAC and PHY link, and support to enable
> > or disable Tx laser.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic•com>
> > ---
> >
> > [...]
> >
> > @@ -46,6 +55,13 @@ struct txgbe_adapter {
> > struct timer_list service_timer;
> > struct work_struct service_task;
> >
> > + u32 flags;
> > +
> > + bool link_up;
>
> Use can reuse the previous field flags to store link status.
>
> Also pls try to avoid placing bools in structures, there are lots of
> discussions around it and how compilers place/declare them, but
> better to know for sure it would work the same way on each setup,
> right?
It is likely a lot of this code goes away one phylink it used.
Andrew
next prev parent reply other threads:[~2022-11-14 20:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:19 [PATCH net-next 0/5] net: WangXun ethernet drivers Mengyuan Lou
2022-11-08 11:19 ` [PATCH net-next 1/5] net: txgbe: Identify PHY and SFP module Mengyuan Lou
2022-11-08 20:52 ` Andrew Lunn
2022-11-09 6:32 ` Jiawen Wu
2022-11-09 13:26 ` Andrew Lunn
2022-11-14 9:34 ` Jiawen Wu
2022-11-14 13:25 ` Andrew Lunn
2022-11-29 8:20 ` Jiawen Wu
2022-11-14 15:34 ` Alexander Lobakin
2022-11-14 20:18 ` Andrew Lunn
2022-11-08 11:19 ` [PATCH net-next 2/5] net: txgbe: Initialize service task Mengyuan Lou
2022-11-08 23:55 ` Jakub Kicinski
2022-11-09 2:16 ` Jiawen Wu
2022-11-09 2:36 ` Andrew Lunn
2022-11-14 15:39 ` Alexander Lobakin
2022-11-08 11:19 ` [PATCH net-next 3/5] net: txgbe: Support to setup link Mengyuan Lou
2022-11-08 21:03 ` Andrew Lunn
2022-11-14 15:48 ` Alexander Lobakin
2022-11-14 20:20 ` Andrew Lunn [this message]
2022-11-08 11:19 ` [PATCH net-next 4/5] net: ngbe: Initialize phy information Mengyuan Lou
2022-11-08 21:10 ` Andrew Lunn
2022-11-11 3:13 ` mengyuanlou
2022-11-11 3:28 ` Andrew Lunn
2022-11-14 16:16 ` Alexander Lobakin
2022-11-08 11:19 ` [PATCH net-next 5/5] net: ngbe: Initialize service task Mengyuan Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3KjFLibpFlws1N5@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandr.lobakin@intel$(echo .)com \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox