From: Jason Gunthorpe <jgg@ziepe•ca>
To: Christoph Hellwig <hch@lst•de>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks•com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Alexandra Winter <wintera@linux•ibm.com>,
Wenjia Zhang <wenjia@linux•ibm.com>,
Marek Szyprowski <m.szyprowski@samsung•com>,
Jaroslav Kysela <perex@perex•cz>, Takashi Iwai <tiwai@suse•com>,
Russell King <linux@armlinux•org.uk>,
Robin Murphy <robin.murphy@arm•com>,
linux-arm-kernel@lists•infradead.org, linux-rdma@vger•kernel.org,
iommu@lists•linux.dev, linux-media@vger•kernel.org,
netdev@vger•kernel.org, linux-s390@vger•kernel.org,
alsa-devel@alsa-project•org
Subject: Re: [PATCH 3/7] RDMA/qib: don't pass bogus GFP_ flags to dma_alloc_coherent
Date: Tue, 15 Nov 2022 16:40:21 -0400 [thread overview]
Message-ID: <Y3P5NWZNLo2+sdnn@ziepe.ca> (raw)
In-Reply-To: <20221113163535.884299-4-hch@lst.de>
On Sun, Nov 13, 2022 at 05:35:31PM +0100, Christoph Hellwig wrote:
> dma_alloc_coherent is an opaque allocator that only uses the GFP_ flags
> for allocation context control. Don't pass GFP_USER which doesn't make
> sense for a kernel DMA allocation or __GFP_COMP which makes no sense
> for an allocation that can't in any way be converted to a page pointer.
>
> Signed-off-by: Christoph Hellwig <hch@lst•de>
> ---
> drivers/infiniband/hw/qib/qib_iba6120.c | 2 +-
> drivers/infiniband/hw/qib/qib_init.c | 21 ++++-----------------
> 2 files changed, 5 insertions(+), 18 deletions(-)
Same same
Acked-by: Jason Gunthorpe <jgg@nvidia•com>
Jason
next prev parent reply other threads:[~2022-11-15 20:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 16:35 stop drivers from passing GFP_COMP to dma_alloc_coherent Christoph Hellwig
2022-11-13 16:35 ` [PATCH 1/7] media: videobuf-dma-contig: use dma_mmap_coherent Christoph Hellwig
2022-11-24 14:10 ` Hans Verkuil
2022-11-29 14:00 ` Christoph Hellwig
2022-11-13 16:35 ` [PATCH 2/7] RDMA/hfi1: don't pass bogus GFP_ flags to dma_alloc_coherent Christoph Hellwig
2022-11-15 20:39 ` Jason Gunthorpe
2022-11-16 14:40 ` Dean Luick
2022-11-16 15:15 ` Robin Murphy
2022-11-16 15:45 ` Christoph Hellwig
2022-11-16 17:49 ` Dean Luick
2022-11-20 20:41 ` Dean Luick
2022-11-16 16:21 ` Dean Luick
2022-11-16 18:37 ` Robin Murphy
2022-11-13 16:35 ` [PATCH 3/7] RDMA/qib: " Christoph Hellwig
2022-11-15 20:40 ` Jason Gunthorpe [this message]
2022-11-13 16:35 ` [PATCH 4/7] cnic: " Christoph Hellwig
2022-11-13 16:35 ` [PATCH 5/7] s390/ism: " Christoph Hellwig
2022-11-16 12:39 ` Wenjia Zhang
2022-11-13 16:35 ` [PATCH 6/7] ALSA: memalloc: don't pass bogus GFP_ flags to dma_alloc_* Christoph Hellwig
2022-11-14 9:04 ` Takashi Iwai
2022-11-21 8:37 ` Christoph Hellwig
2022-11-13 16:35 ` [PATCH 7/7] dma-mapping: reject __GFP_COMP in dma_alloc_attrs Christoph Hellwig
2022-11-14 8:11 ` Leon Romanovsky
2022-11-16 6:11 ` Christoph Hellwig
2022-11-16 7:11 ` Leon Romanovsky
2022-11-14 12:16 ` Marek Szyprowski
2022-11-21 8:39 ` stop drivers from passing GFP_COMP to dma_alloc_coherent Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3P5NWZNLo2+sdnn@ziepe.ca \
--to=jgg@ziepe$(echo .)ca \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=dennis.dalessandro@cornelisnetworks$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=iommu@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=perex@perex$(echo .)cz \
--cc=robin.murphy@arm$(echo .)com \
--cc=tiwai@suse$(echo .)com \
--cc=wenjia@linux$(echo .)ibm.com \
--cc=wintera@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox