From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Andrew Lunn <andrew@lunn•ch>,
Florian Fainelli <f.fainelli@gmail•com>,
UNGLinuxDriver@microchip•com,
bcm-kernel-feedback-list@broadcom•com,
Madalin Bucur <madalin.bucur@oss•nxp.com>,
Camelia Groza <camelia.groza@nxp•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Maxim Kochetkov <fido_max@inbox•ru>,
Sean Anderson <sean.anderson@seco•com>,
Antoine Tenart <atenart@kernel•org>,
Michael Walle <michael@walle•cc>,
Raag Jadav <raagjadav@gmail•com>,
Siddharth Vadapalli <s-vadapalli@ti•com>,
Ong Boon Leong <boon.leong.ong@intel•com>,
Colin Foster <colin.foster@in-advantage•com>,
Marek Behun <marek.behun@nic•cz>
Subject: Re: [PATCH v4 net-next 5/8] net: phylink: explicitly configure in-band autoneg for on-board PHYs
Date: Fri, 18 Nov 2022 10:09:35 +0000 [thread overview]
Message-ID: <Y3dZ35RBf3z83Ph9@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221118000124.2754581-6-vladimir.oltean@nxp.com>
On Fri, Nov 18, 2022 at 02:01:21AM +0200, Vladimir Oltean wrote:
> + if (pl->config->sync_an_inband && !phy_on_sfp(phy)) {
Hmm, this phy_on_sfp() is new to me, and looking at the git history, I
really don't think this does what it claims to do. This returns the
status of phydev->is_on_sfp_module, which is set by this code:
phydev->phy_link_change = phy_link_change;
if (dev) {
phydev->attached_dev = dev;
dev->phydev = phydev;
if (phydev->sfp_bus_attached)
dev->sfp_bus = phydev->sfp_bus;
else if (dev->sfp_bus)
phydev->is_on_sfp_module = true;
}
... which is very wrong. "dev" here is the net_device, and a net_device
will have its sfp_bus member set when there is a SFP cage present,
which may be behind a off-SFP PHY.
This means that when a PHY is attached by the network driver in their
ndo_open, if there is a SFP bus on the interface (such as on the
Macchiatobin board), the above will set is_on_sfp_module true for the
on-board PHY even though it is not in the SFP module.
Essentially, commit b834489bcecc is incorrect, and needs to be fixed
before use is made of phy_on_sfp() outside of the broadcom driver.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-11-18 10:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 0:01 [PATCH v4 net-next 0/8] Let phylink manage in-band AN for the PHY Vladimir Oltean
2022-11-18 0:01 ` [PATCH v4 net-next 1/8] net: phylink: let phylink_sfp_config_phy() determine the MLO_AN_* mode to use Vladimir Oltean
2022-11-18 0:01 ` [PATCH v4 net-next 2/8] net: phylink: introduce generic method to query PHY in-band autoneg capability Vladimir Oltean
2022-11-18 15:11 ` Sean Anderson
2022-11-18 15:42 ` Vladimir Oltean
2022-11-18 15:49 ` Sean Anderson
2022-11-18 15:56 ` Vladimir Oltean
2022-11-18 15:57 ` Sean Anderson
2022-11-18 16:00 ` Vladimir Oltean
2022-11-22 9:21 ` Russell King (Oracle)
2022-11-22 9:41 ` Vladimir Oltean
2022-11-22 9:52 ` Vladimir Oltean
2022-11-18 0:01 ` [PATCH v4 net-next 3/8] net: phy: bcm84881: move the in-band capability check where it belongs Vladimir Oltean
2022-11-22 9:38 ` Russell King (Oracle)
2022-11-22 10:01 ` Vladimir Oltean
2022-11-22 11:16 ` Russell King (Oracle)
2022-11-22 12:11 ` Vladimir Oltean
2022-11-22 16:58 ` Russell King (Oracle)
2022-11-22 17:56 ` Vladimir Oltean
2022-11-22 18:14 ` Vladimir Oltean
2022-11-22 18:28 ` Russell King (Oracle)
2022-11-22 19:36 ` Vladimir Oltean
2022-11-23 12:08 ` Russell King (Oracle)
2022-11-23 13:11 ` Russell King (Oracle)
2022-11-25 12:30 ` Vladimir Oltean
2022-11-25 13:43 ` Russell King (Oracle)
2022-11-25 15:35 ` Vladimir Oltean
2022-11-27 22:14 ` Russell King (Oracle)
2022-11-29 13:40 ` Russell King (Oracle)
2022-11-29 13:43 ` Russell King (Oracle)
2022-11-29 14:07 ` Andrew Lunn
2022-11-22 12:24 ` Vladimir Oltean
2022-11-22 17:51 ` Russell King (Oracle)
2022-11-18 0:01 ` [PATCH v4 net-next 4/8] net: phylink: add option to sync in-band autoneg setting between PCS and PHY Vladimir Oltean
2022-11-18 0:01 ` [PATCH v4 net-next 5/8] net: phylink: explicitly configure in-band autoneg for on-board PHYs Vladimir Oltean
2022-11-18 10:09 ` Russell King (Oracle) [this message]
2022-11-18 11:25 ` Vladimir Oltean
2022-11-18 14:37 ` Russell King (Oracle)
2022-11-18 0:01 ` [PATCH v4 net-next 6/8] net: phy: mscc: configure in-band auto-negotiation for VSC8514 Vladimir Oltean
2022-11-18 0:01 ` [PATCH v4 net-next 7/8] net: phy: at803x: validate in-band autoneg for AT8031/AT8033 Vladimir Oltean
2022-11-18 0:01 ` [PATCH v4 net-next 8/8] net: opt MAC drivers which use Lynx PCS into phylink sync_an_inband Vladimir Oltean
2022-11-21 18:38 ` [PATCH v4 net-next 0/8] Let phylink manage in-band AN for the PHY Sean Anderson
2022-11-21 19:44 ` Vladimir Oltean
2022-11-21 22:42 ` Sean Anderson
2022-11-22 0:17 ` Vladimir Oltean
2022-11-22 16:10 ` Sean Anderson
2022-11-22 16:30 ` Vladimir Oltean
2022-11-22 16:45 ` Sean Anderson
2022-11-22 17:59 ` Russell King (Oracle)
2022-11-22 18:09 ` Sean Anderson
2022-11-22 9:16 ` Russell King (Oracle)
2022-12-02 12:16 ` Maxim Kochetkov
2022-12-05 17:19 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3dZ35RBf3z83Ph9@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=atenart@kernel$(echo .)org \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=boon.leong.ong@intel$(echo .)com \
--cc=camelia.groza@nxp$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=colin.foster@in-advantage$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fido_max@inbox$(echo .)ru \
--cc=hkallweit1@gmail$(echo .)com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=madalin.bucur@oss$(echo .)nxp.com \
--cc=marek.behun@nic$(echo .)cz \
--cc=michael@walle$(echo .)cc \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=raagjadav@gmail$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=sean.anderson@seco$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox