From: Simon Horman <simon.horman@corigine•com>
To: Ilya Maximets <i.maximets@ovn•org>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
Marcelo Leitner <mleitner@redhat•com>,
Davide Caratti <dcaratti@redhat•com>,
Eelco Chaudron <echaudro@redhat•com>,
Tianyu Yuan <tianyu.yuan@corigine•com>,
dev@openvswitch•org, oss-drivers <oss-drivers@corigine•com>,
netdev@vger•kernel.org, Cong Wang <xiyou.wangcong@gmail•com>,
Oz Shlomo <ozsh@nvidia•com>, Paul Blakey <paulb@nvidia•com>,
Vlad Buslov <vladbu@nvidia•com>
Subject: Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload stats
Date: Tue, 22 Nov 2022 12:31:16 +0100 [thread overview]
Message-ID: <Y3yzBJ87Atg+EeAd@corigine.com> (raw)
In-Reply-To: <Y0/tbYTy5Up9X1m4@corigine.com>
On Wed, Oct 19, 2022 at 02:28:29PM +0200, Simon Horman wrote:
> On Wed, Oct 19, 2022 at 02:17:42PM +0200, Ilya Maximets wrote:
> > On 10/19/22 10:12, Simon Horman wrote:
> > > On Fri, Oct 14, 2022 at 10:40:30AM -0400, Jamal Hadi Salim wrote:
> > >> On Fri, Oct 14, 2022 at 9:00 AM Ilya Maximets <i.maximets@ovn•org> wrote:
> > >>>
> > >>
> > >> [..]
> > >>>> I thought it was pipe but maybe it is OK(in my opinion that is a bad code
> > >>>> for just "count"). We have some (at least NIC) hardware folks on the list.
> > >>>
> > >>> IIRC, 'OK' action will stop the processing for the packet, so it can
> > >>> only be used as a last action in the list. But we need to count packets
> > >>> as a very first action in the list. So, that doesn't help.
> > >>>
> > >>
> > >> That's why i said it is a bad code - but i believe it's what some of
> > >> the hardware
> > >> people are doing. Note: it's only bad if you have more actions after because
> > >> it aborts the processing pipeline.
> > >>
> > >>>> Note: we could create an alias to PIPE and call it COUNT if it helps.
> > >>>
> > >>> Will that help with offloading of that action? Why the PIPE is not
> > >>> offloadable in the first place and will COUNT be offloadable?
> > >>
> > >> Offloadable is just a semantic choice in this case. If someone is
> > >> using OK to count today - they could should be able to use PIPE
> > >> instead (their driver needs to do some transformation of course).
> > >
> > > FWIIW, yes, that is my thinking too.
> >
> > I don't know that code well, but I thought that tcf_gact_offload_act_setup()
> > is a generic function. And since it explicitly forbids offload of PIPE
> > action, no drivers can actually offload it even if they want to.
>
> Sure, but I would expect that can be changed.
RFC kernel patch posted:
* https://lore.kernel.org/netdev/20221122112020.922691-1-simon.horman@corigine.com/
> > So it's not really a driver's choice in the current kernel code. Or am I
> > missing something?
> >
> > Best regards, Ilya Maximets.
next prev parent reply other threads:[~2022-11-22 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220914141923.1725821-1-simon.horman@corigine.com>
[not found] ` <eeb0c590-7364-a00e-69fc-2326678d6bdf@ovn.org>
[not found] ` <PH0PR13MB4793A85169BB60B8609B192194499@PH0PR13MB4793.namprd13.prod.outlook.com>
[not found] ` <0aac2127-0b14-187e-0adb-7d6b8fe8cfb1@ovn.org>
[not found] ` <e71b2bf2-cfd5-52f4-5fd4-1c852f2a8c6c@ovn.org>
[not found] ` <00D45065-3D74-4C4C-8988-BFE0CEB3BE2F@redhat.com>
[not found] ` <fe0cd650-0d4a-d871-5c0b-b1c831c8d0cc@ovn.org>
2022-10-07 13:21 ` [ovs-dev] [PATCH] tests: fix reference output for meter offload stats Marcelo Leitner
2022-10-07 14:39 ` Davide Caratti
2022-10-07 15:01 ` Marcelo Leitner
2022-10-07 15:59 ` Jamal Hadi Salim
2022-10-07 17:37 ` Marcelo Leitner
2022-10-08 12:32 ` Jamal Hadi Salim
2022-10-14 13:00 ` Ilya Maximets
2022-10-14 14:40 ` Jamal Hadi Salim
2022-10-19 8:12 ` Simon Horman
2022-10-19 12:17 ` Ilya Maximets
2022-10-19 12:28 ` Simon Horman
2022-11-22 11:31 ` Simon Horman [this message]
2022-10-07 15:03 ` Eelco Chaudron
2022-10-10 5:55 ` Tianyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3yzBJ87Atg+EeAd@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=dcaratti@redhat$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=echaudro@redhat$(echo .)com \
--cc=i.maximets@ovn$(echo .)org \
--cc=jhs@mojatatu$(echo .)com \
--cc=mleitner@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=ozsh@nvidia$(echo .)com \
--cc=paulb@nvidia$(echo .)com \
--cc=tianyu.yuan@corigine$(echo .)com \
--cc=vladbu@nvidia$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox