From: Dan Carpenter <error27@gmail•com>
To: Jay Vosburgh <j.vosburgh@gmail•com>,
Jonathan Toppins <jtoppins@redhat•com>,
Pavan Chebbi <pavan.chebbi@broadcom•com>
Cc: Veaceslav Falico <vfalico@gmail•com>,
Andy Gospodarek <andy@greyhouse•net>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jonathan Toppins <jtoppins@redhat•com>,
netdev@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: [PATCH net-next v2] bonding: uninitialized variable in bond_miimon_inspect()
Date: Mon, 28 Nov 2022 14:06:14 +0300 [thread overview]
Message-ID: <Y4SWJlh3ohJ6EPTL@kili> (raw)
The "ignore_updelay" variable needs to be initialized to false.
Fixes: f8a65ab2f3ff ("bonding: fix link recovery in mode 2 when updelay is nonzero")
Signed-off-by: Dan Carpenter <error27@gmail•com>
---
v2: Re-order so the declarations are in reverse Christmas tree order
Don't forget about:
drivers/net/bonding/bond_main.c:5071 bond_update_slave_arr() warn: missing error code here? 'bond_3ad_get_active_agg_info()' failed. 'ret' = '0'
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index c87481033995..e01bb0412f1c 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2524,10 +2524,10 @@ static int bond_slave_info_query(struct net_device *bond_dev, struct ifslave *in
/* called with rcu_read_lock() */
static int bond_miimon_inspect(struct bonding *bond)
{
+ bool ignore_updelay = false;
int link_state, commit = 0;
struct list_head *iter;
struct slave *slave;
- bool ignore_updelay;
if (BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP) {
ignore_updelay = !rcu_dereference(bond->curr_active_slave);
--
2.35.1
next reply other threads:[~2022-11-28 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:06 Dan Carpenter [this message]
2022-11-28 13:45 ` [PATCH net-next v2] bonding: uninitialized variable in bond_miimon_inspect() Pavan Chebbi
2022-11-28 14:36 ` Dan Carpenter
2022-11-28 14:40 ` Dan Carpenter
2022-11-28 15:05 ` Pavan Chebbi
2022-11-28 18:30 ` Jay Vosburgh
2022-11-29 12:51 ` Dan Carpenter
2022-12-01 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4SWJlh3ohJ6EPTL@kili \
--to=error27@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=jtoppins@redhat$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox