From: Jiri Pirko <jiri@resnulli•us>
To: Vincent Mailhol <mailhol.vincent@wanadoo•fr>
Cc: Jiri Pirko <jiri@nvidia•com>,
netdev@vger•kernel.org, Jakub Kicinski <kuba@kernel•org>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
linux-kernel@vger•kernel.org,
Boris Brezillon <bbrezillon@kernel•org>,
Arnaud Ebalard <arno@natisbad•org>,
Srujana Challa <schalla@marvell•com>,
Kurt Kanzenbach <kurt@linutronix•de>,
Andrew Lunn <andrew@lunn•ch>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
Michael Chan <michael.chan@broadcom•com>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Dimitris Michailidis <dmichail@fungible•com>,
Yisen Zhuang <yisen.zhuang@huawei•com>,
Salil Mehta <salil.mehta@huawei•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Sunil Goutham <sgoutham@marvell•com>,
Linu Cherian <lcherian@marvell•com>,
Geetha sowjanya <gakula@marvell•com>,
Jerin Jacob <jerinj@marvell•com>, hariprasad <hkelam@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Taras Chornyi <tchornyi@marvell•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>,
Ido Schimmel <idosch@nvidia•com>, Petr Machata <petrm@nvidia•com>,
Simon Horman <simon.horman@corigine•com>,
Shannon Nelson <snelson@pensando•io>,
drivers@pensando•io, Ariel Elior <aelior@marvell•com>,
Manish Chopra <manishc@marvell•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
Vadim Fedorenko <vadfed@fb•com>,
Richard Cochran <richardcochran@gmail•com>,
Vadim Pasternak <vadimp@mellanox•com>,
Shalom Toledo <shalomt@mellanox•com>,
linux-crypto@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
linux-rdma@vger•kernel.org, oss-drivers@corigine•com,
Jiri Pirko <jiri@mellanox•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Hao Chen <chenhao288@hisilicon•com>,
Guangbin Huang <huangguangbin2@huawei•com>,
Minghao Chi <chi.minghao@zte•com.cn>,
Shijith Thotton <sthotton@marvell•com>
Subject: Re: [PATCH net-next v5 1/4] net: devlink: let the core report the driver name instead of the drivers
Date: Tue, 29 Nov 2022 09:24:58 +0100 [thread overview]
Message-ID: <Y4XB2iBqceQfFZem@nanopsycho> (raw)
In-Reply-To: <20221129000550.3833570-2-mailhol.vincent@wanadoo.fr>
Tue, Nov 29, 2022 at 01:05:47AM CET, mailhol.vincent@wanadoo•fr wrote:
>The driver name is available in device_driver::name. Right now,
>drivers still have to report this piece of information themselves in
>their devlink_ops::info_get callback function.
>
>In order to factorize code, make devlink_nl_info_fill() add the driver
>name attribute.
>
>nla_put() does not check if an attribute already exists and
>unconditionally reserves new space [1]. To avoid attribute
>duplication, clean-up all the drivers which are currently reporting
>the driver name in their callback.
This para with the link below should be removed, no need for it.
Otherwise, code looks fine.
Reviewed-by: Jiri Pirko <jiri@nvidia•com>
next prev parent reply other threads:[~2022-11-29 8:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 0:05 [PATCH net-next v5 0/4] net: devlink: return the driver name in devlink_nl_info_fill Vincent Mailhol
2022-11-29 0:05 ` [PATCH net-next v5 1/4] net: devlink: let the core report the driver name instead of the drivers Vincent Mailhol
2022-11-29 8:24 ` Jiri Pirko [this message]
2022-11-30 0:29 ` Vadim Fedorenko
2022-11-29 0:05 ` [PATCH net-next v5 2/4] net: devlink: remove devlink_info_driver_name_put() Vincent Mailhol
2022-11-29 0:23 ` Keller, Jacob E
2022-11-29 1:10 ` Vincent MAILHOL
2022-11-29 1:19 ` Keller, Jacob E
2022-11-29 8:25 ` Jiri Pirko
2022-11-29 9:37 ` Vincent MAILHOL
2022-11-29 16:23 ` Jakub Kicinski
2022-11-29 0:05 ` [PATCH net-next v5 3/4] net: devlink: make the devlink_ops::info_get() callback optional Vincent Mailhol
2022-11-29 0:24 ` [Intel-wired-lan] " Keller, Jacob E
2022-11-29 8:26 ` Jiri Pirko
2022-11-29 0:05 ` [PATCH net-next v5 4/4] net: devlink: clean-up empty devlink_ops::info_get() Vincent Mailhol
2022-11-29 8:27 ` Jiri Pirko
2022-11-29 0:25 ` [PATCH net-next v5 0/4] net: devlink: return the driver name in devlink_nl_info_fill Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4XB2iBqceQfFZem@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=aelior@marvell$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arno@natisbad$(echo .)org \
--cc=bbrezillon@kernel$(echo .)org \
--cc=chenhao288@hisilicon$(echo .)com \
--cc=chi.minghao@zte$(echo .)com.cn \
--cc=davem@davemloft$(echo .)net \
--cc=dmichail@fungible$(echo .)com \
--cc=drivers@pensando$(echo .)io \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hkelam@marvell$(echo .)com \
--cc=huangguangbin2@huawei$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jerinj@marvell$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=lcherian@marvell$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=manishc@marvell$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=schalla@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shalomt@mellanox$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=sthotton@marvell$(echo .)com \
--cc=tchornyi@marvell$(echo .)com \
--cc=vadfed@fb$(echo .)com \
--cc=vadimp@mellanox$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox