From: Andrew Lunn <andrew@lunn•ch>
To: Oleksij Rempel <o.rempel@pengutronix•de>
Cc: Jacob Keller <jacob.e.keller@intel•com>,
Woojung Huh <woojung.huh@microchip•com>,
UNGLinuxDriver@microchip•com,
Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, Arun.Ramadoss@microchip•com,
linux-kernel@vger•kernel.org, kernel@pengutronix•de
Subject: Re: [PATCH v1 00/26] net: dsa: microchip: stats64, fdb, error
Date: Tue, 29 Nov 2022 15:15:03 +0100 [thread overview]
Message-ID: <Y4YT5wfckSO1sfRw@lunn.ch> (raw)
In-Reply-To: <20221129053539.GA25526@pengutronix.de>
On Tue, Nov 29, 2022 at 06:35:39AM +0100, Oleksij Rempel wrote:
> On Mon, Nov 28, 2022 at 03:09:19PM -0800, Jacob Keller wrote:
> >
> >
> > On 11/28/2022 3:59 AM, Oleksij Rempel wrote:
> > > This patch series is a result of maintaining work on ksz8 part of
> > > microchip driver. It includes stats64 and fdb support. Error handling.
> > > Loopback fix and so on...
> > >
> > > Oleksij Rempel (26):
> > > net: dsa: microchip: add stats64 support for ksz8 series of switches
> > > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix port validation and VID
> > > information
> > > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix not complete fdb
> > > extraction
> > > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix time stamp extraction
> > > net: dsa: microchip: ksz8: ksz8_fdb_dump: do not extract ghost entry
> > > from empty table
> > > net: dsa: microchip: ksz8863_smi: fix bulk access
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): remove timestamp support
> > > net: dsa: microchip: make ksz8_r_dyn_mac_table() static
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): remove fid support
> > > net: dsa: microchip: ksz8: refactor ksz8_fdb_dump()
> > > net: dsa: microchip: ksz8: ksz8_fdb_dump: dump static MAC table
> > > net: dsa: microchip: ksz8: move static mac table operations to a
> > > separate functions
> > > net: dsa: microchip: ksz8: add fdb_add/del support
> > > net: dsa: microchip: KSZ88x3 fix loopback support
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): move main part of the
> > > code out of if statement
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): use ret instead of rc
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): ksz: do not return EAGAIN
> > > on timeout
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): return read/write error
> > > if we got any
> > > net: dsa: microchip: ksz8_r_dyn_mac_table(): use entries variable to
> > > signal 0 entries
> > > net: dsa: microchip: make ksz8_r_sta_mac_table() static
> > > net: dsa: microchip: ksz8_r_sta_mac_table(): do not use error code for
> > > empty entries
> > > net: dsa: microchip: ksz8_r_sta_mac_table(): make use of error values
> > > provided by read/write functions
> > > net: dsa: microchip: make ksz8_w_sta_mac_table() static
> > > net: dsa: microchip: ksz8_w_sta_mac_table(): make use of error values
> > > provided by read/write functions
> > > net: dsa: microchip: remove ksz_port:on variable
> > > net: dsa: microchip: ksz8: do not force flow control by default
> > >
> >
> >
> > My understanding is that we typically limit series to 15 patches. Do you
> > have some justification for why this goes over 15 and can't reasonably be
> > split into two series?
> >
> > At a glance it seems like a bunch of smaller cleanups.
>
> The previous patch set got request to do more clean ups:
> https://lore.kernel.org/all/20221124101458.3353902-1-o.rempel@pengutronix.de/
>
> I need to show, there are already more patches in the queue.
There is some psychology involved here. I see 26 patches and decide i
need to allocate 30 minutes to this sometime, and put the review off
until later, without even looking at them. If i get 5 patches, i
probably just do it, knowing i will be finished pretty quickly. My
guess is, 5 patches a day for 5 days will be merged faster than 26
patches in one go.
Andrew
next prev parent reply other threads:[~2022-11-29 14:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:59 [PATCH v1 00/26] net: dsa: microchip: stats64, fdb, error Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 01/26] net: dsa: microchip: add stats64 support for ksz8 series of switches Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 02/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: fix port validation and VID information Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 03/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: fix not complete fdb extraction Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 04/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: fix time stamp extraction Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 05/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: do not extract ghost entry from empty table Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 06/26] net: dsa: microchip: ksz8863_smi: fix bulk access Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 07/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): remove timestamp support Oleksij Rempel
2022-11-29 7:16 ` Arun.Ramadoss
2022-11-28 11:59 ` [PATCH v1 08/26] net: dsa: microchip: make ksz8_r_dyn_mac_table() static Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 09/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): remove fid support Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 10/26] net: dsa: microchip: ksz8: refactor ksz8_fdb_dump() Oleksij Rempel
2022-11-29 8:29 ` Arun.Ramadoss
2022-11-29 8:50 ` Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 11/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: dump static MAC table Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 12/26] net: dsa: microchip: ksz8: move static mac table operations to a separate functions Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 13/26] net: dsa: microchip: ksz8: add fdb_add/del support Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 14/26] net: dsa: microchip: KSZ88x3 fix loopback support Oleksij Rempel
2022-11-29 6:42 ` Arun.Ramadoss
2022-11-28 11:59 ` [PATCH v1 15/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): move main part of the code out of if statement Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 16/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): use ret instead of rc Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 17/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): ksz: do not return EAGAIN on timeout Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 18/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): return read/write error if we got any Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 19/26] net: dsa: microchip: ksz8_r_dyn_mac_table(): use entries variable to signal 0 entries Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 20/26] net: dsa: microchip: make ksz8_r_sta_mac_table() static Oleksij Rempel
2022-11-29 5:08 ` Arun.Ramadoss
2022-11-28 11:59 ` [PATCH v1 21/26] net: dsa: microchip: ksz8_r_sta_mac_table(): do not use error code for empty entries Oleksij Rempel
2022-11-29 5:25 ` Arun.Ramadoss
2022-11-29 5:56 ` Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 22/26] net: dsa: microchip: ksz8_r_sta_mac_table(): make use of error values provided by read/write functions Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 23/26] net: dsa: microchip: make ksz8_w_sta_mac_table() static Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 24/26] net: dsa: microchip: ksz8_w_sta_mac_table(): make use of error values provided by read/write functions Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 25/26] net: dsa: microchip: remove ksz_port:on variable Oleksij Rempel
2022-11-28 11:59 ` [PATCH v1 26/26] net: dsa: microchip: ksz8: do not force flow control by default Oleksij Rempel
2022-11-28 13:51 ` [PATCH v1 00/26] net: dsa: microchip: stats64, fdb, error Andrew Lunn
2022-11-28 21:05 ` Jakub Kicinski
2022-11-28 23:09 ` Jacob Keller
2022-11-29 5:35 ` Oleksij Rempel
2022-11-29 14:15 ` Andrew Lunn [this message]
2022-11-30 5:34 ` Oleksij Rempel
-- strict thread matches above, loose matches on Subject: below --
2022-11-28 12:00 Oleksij Rempel
2022-11-28 12:10 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4YT5wfckSO1sfRw@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Arun.Ramadoss@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox