From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Lucas Stach <l.stach@pengutronix•de>
Cc: Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
netdev@vger•kernel.org, kernel@pengutronix•de,
patchwork-lst@pengutronix•de
Subject: Re: [PATCH] net: phylink: don't try to stop halted PHY
Date: Thu, 1 Dec 2022 18:09:10 +0000 [thread overview]
Message-ID: <Y4jtxg67HW80EXU2@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221201175302.2732938-1-l.stach@pengutronix.de>
On Thu, Dec 01, 2022 at 06:53:02PM +0100, Lucas Stach wrote:
> When the PHY driver has encountered a non-recoverable error condition, e.g
> due to a failure in MDIO communication it may have already halted the PHY
> by calling phy_error(). If that is the case then phylink should not try to
> stop the PHY again.
No. phylib doesn't say this is necessary, and if you grep the many
network drivers, they don't do such a test.
If we want to do this then obviously all network drivers need to be
updated to do the same test before calling phy_stop()... but it would
be better if phylib avoided being rather silly in this case.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-12-01 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 17:53 [PATCH] net: phylink: don't try to stop halted PHY Lucas Stach
2022-12-01 18:09 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4jtxg67HW80EXU2@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=l.stach@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=patchwork-lst@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox