From: Andrew Lunn <andrew@lunn•ch>
To: Sean Anderson <sean.anderson@seco•com>
Cc: Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
netdev@vger•kernel.org, Eric Dumazet <edumazet@google•com>,
linux-kernel@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>
Subject: Re: [PATCH net-next] net: phy: swphy: Only warn once for unknown speed
Date: Thu, 1 Dec 2022 21:48:21 +0100 [thread overview]
Message-ID: <Y4kTFRBvsN/JCeNd@lunn.ch> (raw)
In-Reply-To: <20221201202254.561103-1-sean.anderson@seco.com>
On Thu, Dec 01, 2022 at 03:22:53PM -0500, Sean Anderson wrote:
> swphy_read_reg is called quite frequently during normal operation. If an
> invalid speed is used for state, then it can turn dmesg into a firehose.
> Although the first warn will likely contain a backtrace for the
> offending driver, later warnings will usually just contain a backtrace
> from the phy state machine. Just warn once.
Hi Sean
How did you trigger this? I have a patch in this area as well, which i
want Russells opinion on. I'm wondering if we are hitting the same
problem.
Andrew
prev parent reply other threads:[~2022-12-01 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 20:22 [PATCH net-next] net: phy: swphy: Only warn once for unknown speed Sean Anderson
2022-12-01 20:48 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4kTFRBvsN/JCeNd@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sean.anderson@seco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox