From: Jason Gunthorpe <jgg@ziepe•ca>
To: "Ertman, David M" <david.m.ertman@intel•com>
Cc: Saeed Mahameed <saeed@kernel•org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"kuba@kernel•org" <kuba@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"edumazet@google•com" <edumazet@google•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Saleem, Shiraz" <shiraz.saleem@intel•com>,
"Ismail, Mustafa" <mustafa.ismail@intel•com>,
"leonro@nvidia•com" <leonro@nvidia•com>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"G, GurucharanX" <gurucharanx.g@intel•com>
Subject: Re: [PATCH net 2/4] ice: Correctly handle aux device when num channels change
Date: Mon, 12 Dec 2022 19:53:58 -0400 [thread overview]
Message-ID: <Y5e/FjounudVaf4p@ziepe.ca> (raw)
In-Reply-To: <MW5PR11MB5811C27393271A563A009821DDE29@MW5PR11MB5811.namprd11.prod.outlook.com>
On Mon, Dec 12, 2022 at 05:03:39PM +0000, Ertman, David M wrote:
> > On Fri, Dec 09, 2022 at 11:28:28AM -0800, Saeed Mahameed wrote:
> >
> > > IMO it's wrong to re-initialize a parallel subsystems due to an ethtool,
> > > ethtool is meant to control the netdev interface, not rdma.
> >
> > We've gotten into locking trouble doing stuff like this before.
> >
> > If you are holding any locks do not try to unplug/plug an aux device.
> >
> > Jason
>
> The unplug/plug is done outside the ethtool context. No locks are being held.
That's a good, trick, so I'm skeptical *no* locks are held.
Jason
next prev parent reply other threads:[~2022-12-12 23:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 21:10 [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2022-12-07 (ice) Tony Nguyen
2022-12-07 21:10 ` [PATCH net 1/4] ice: Create a separate kthread to handle ptp extts work Tony Nguyen
2022-12-07 22:19 ` Saeed Mahameed
2022-12-07 23:22 ` Jacob Keller
2022-12-08 0:27 ` Richard Cochran
2022-12-09 17:07 ` Tony Nguyen
2022-12-07 21:10 ` [PATCH net 2/4] ice: Correctly handle aux device when num channels change Tony Nguyen
2022-12-07 22:25 ` Saeed Mahameed
2022-12-09 17:21 ` Ertman, David M
2022-12-09 19:28 ` Saeed Mahameed
2022-12-09 19:32 ` Jason Gunthorpe
2022-12-12 17:03 ` Ertman, David M
2022-12-12 23:53 ` Jason Gunthorpe [this message]
2022-12-16 19:08 ` [PATCH net 2/4] ice: git send-email --suppress-cc=all --to e1000-patches@eclists•intel.com Ertman, David M
2022-12-07 21:10 ` [PATCH net 3/4] ice: Fix deadlock on the rtnl_mutex Tony Nguyen
2022-12-07 21:10 ` [PATCH net 4/4] ice: Fix broken link in ice NAPI doc Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5e/FjounudVaf4p@ziepe.ca \
--to=jgg@ziepe$(echo .)ca \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.m.ertman@intel$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gurucharanx.g@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leonro@nvidia$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=mustafa.ismail@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeed@kernel$(echo .)org \
--cc=shiraz.saleem@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox