From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Liang Xu <lxu@maxlinear•com>
Cc: Michael Walle <michael@walle•cc>,
"andrew@lunn•ch" <andrew@lunn•ch>,
"davem@davemloft•net" <davem@davemloft•net>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
Hauke Mehrtens <hmehrtens@maxlinear•com>,
"kuba@kernel•org" <kuba@kernel•org>,
"Ismail, Mohammad Athari" <mohammad.athari.ismail@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Thomas Mohren <tmohren@maxlinear•com>
Subject: Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function
Date: Wed, 21 Dec 2022 12:20:43 +0000 [thread overview]
Message-ID: <Y6L6G3bPVony+B5X@shell.armlinux.org.uk> (raw)
In-Reply-To: <PH7PR19MB56130FA71635455AE9DB8524BDE09@PH7PR19MB5613.namprd19.prod.outlook.com>
Hi,
On Wed, Dec 14, 2022 at 09:16:46AM +0000, Liang Xu wrote:
> From: Michael Walle <michael@walle•cc>
> Sent: Wednesday, December 14, 2022 5:00 PM
> Subject: Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function
>
> This email was sent from outside of MaxLinear.
>
>
> Subject is missing the correct target, "net" in this case.
>
> > GPY need 3 seconds to switch out of loopback mode.
>
> What does that mean, what goes wrong with the current 100ms?
> Could you elaborate a bit more and update the commit message
> and the comment? Is this true for any GPY PHY supported by
> this driver?
>
> The internal state machine need almost 3s to fully restore to original state when leaving the loopback mode.
> This is true for all models supported by this driver.
> I will update the commit message and fix the target.
> Thank you.
When you state that it takes almost 3 seconds to fully restore the
state, what are you basing that upon - what are you using to determine
that the state has been fully restored?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-12-21 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 8:29 [PATCH] net: phy: enhance Maxlinear GPY loopback disable function Xu Liang
2022-12-14 9:00 ` Michael Walle
[not found] ` <PH7PR19MB56130FA71635455AE9DB8524BDE09@PH7PR19MB5613.namprd19.prod.outlook.com>
2022-12-21 12:20 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6L6G3bPVony+B5X@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=hmehrtens@maxlinear$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lxu@maxlinear$(echo .)com \
--cc=michael@walle$(echo .)cc \
--cc=mohammad.athari.ismail@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tmohren@maxlinear$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox