Subject: Re: [PATCH net-next v7] net: ngbe: Add ngbe mdio bus driver.

From: Andrew Lunn <[email-masked]>
Date: Wed, 11 Jan 2023 03:28:11 +0100

On Tue, Jan 10, 2023 at 06:19:07PM -0800, Jakub Kicinski wrote:
> On Mon, 9 Jan 2023 17:49:12 +0100 Andrew Lunn wrote:
> > On Mon, Jan 09, 2023 at 11:35:08PM +0800, Mengyuan Lou wrote:
> > > Add mdio bus register for ngbe.
> > > The internal phy and external phy need to be handled separately.
> > > Add phy changed event detection.
> > > 
> > > Signed-off-by: Mengyuan Lou <[email-masked]>  
> > 
> > Reviewed-by: Andrew Lunn <[email-masked]>
> 
> Any preference on this getting merged as is vs Mengyuan implementing
> the c45 support via separate callbacks? I just applied the patches
> adding the new callbacks to net-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=ef1757ef58467310a285e57e6dbf6cf8314e5080

Hi Jakub

Thanks for merging these patches. I forget how many patches there are
in total, something like 60, so there are a few more series to
come. Many more drivers still need splitting.

If Mengyuan wants to split C22 and C45 that would be nice, but since
this is a new requirement, i would not insist on it.

  Andrew