From: Jiri Pirko <jiri@resnulli•us>
To: Sean Anderson <seanga2@gmail•com>
Cc: Madalin Bucur <madalin.bucur@nxp•com>,
"David S . Miller" <davem@davemloft•net>,
Sean Anderson <sean.anderson@seco•com>,
netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Christian Zigotzky <info@xenosoft•de>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net] net: dpaa: Fix dtsec check for PCS availability
Date: Tue, 3 Jan 2023 10:15:54 +0100 [thread overview]
Message-ID: <Y7PyStu4s79FAHWH@nanopsycho> (raw)
In-Reply-To: <20230103065038.2174637-1-seanga2@gmail.com>
Tue, Jan 03, 2023 at 07:50:38AM CET, seanga2@gmail•com wrote:
>We want to fail if the PCS is not available, not if it is available. Fix
It is odd to read plural maiestaticus in patch desctiption :) Better to
stick with describing what code does wrong and then telling the codebase
what to do.
>this condition.
>
>Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
>Reported-by: Christian Zigotzky <info@xenosoft•de>
>Signed-off-by: Sean Anderson <seanga2@gmail•com>
Reviewed-by: Jiri Pirko <jiri@nvidia•com>
next prev parent reply other threads:[~2023-01-03 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 6:50 [PATCH net] net: dpaa: Fix dtsec check for PCS availability Sean Anderson
2023-01-03 9:15 ` Jiri Pirko [this message]
2023-01-03 14:37 ` Sean Anderson
2023-01-03 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7PyStu4s79FAHWH@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=info@xenosoft$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=madalin.bucur@nxp$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sean.anderson@seco$(echo .)com \
--cc=seanga2@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox