Subject: Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support

From: Andrew Lunn <[email-masked]>
Date: Wed, 4 Jan 2023 01:34:12 +0100

> @@ -192,10 +194,16 @@ static int e1000_get_link_ksettings(struct net_device *netdev,
>  	if (hw->phy.media_type != e1000_media_type_copper)
>  		cmd->base.eth_tp_mdix_ctrl = ETH_TP_MDI_INVALID;
>  
> +	lpa_t = mii_stat1000_to_ethtool_lpa_t(adapter->phy_regs.stat1000);
> +	lp_advertising = lpa_t |
> +	mii_lpa_to_ethtool_lpa_t(adapter->phy_regs.lpa);

The indentation here is a bit odd.

I would also suggest you split this patch into two, since you are
making two changes, adding pause, and adding LPA.

       Andrew