From: Ido Schimmel <idosch@nvidia•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, kuba@kernel•org,
pabeni@redhat•com, edumazet@google•com,
michael.chan@broadcom•com, yisen.zhuang@huawei•com,
salil.mehta@huawei•com, jesse.brandeburg@intel•com,
anthony.l.nguyen@intel•com, tariqt@nvidia•com, saeedm@nvidia•com,
leon@kernel•org, petrm@nvidia•com, mailhol.vincent@wanadoo•fr,
jacob.e.keller@intel•com, gal@nvidia•com
Subject: Re: [patch net-next v2 6/9] devlink: convert linecards dump to devlink_nl_instance_iter_dump()
Date: Sun, 8 Jan 2023 19:01:57 +0200 [thread overview]
Message-ID: <Y7r3BQphwVLuaBZ/@shredder> (raw)
In-Reply-To: <20230107101151.532611-7-jiri@resnulli.us>
On Sat, Jan 07, 2023 at 11:11:47AM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia•com>
>
> Benefit from recently introduced instance iteration and convert
> linecards .dumpit generic netlink callback to use it.
>
> Signed-off-by: Jiri Pirko <jiri@nvidia•com>
Code looks good to me and consistent with other objects:
Reviewed-by: Ido Schimmel <idosch@nvidia•com>
next prev parent reply other threads:[~2023-01-08 17:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 10:11 [patch net-next v2 0/9] devlink: features, linecard and reporters locking cleanup Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 1/9] devlink: remove devlink features Jiri Pirko
2023-01-08 15:32 ` Ido Schimmel
2023-01-09 8:41 ` Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 2/9] devlink: remove linecards lock Jiri Pirko
2023-01-08 15:42 ` Ido Schimmel
2023-01-09 8:42 ` Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 3/9] devlink: remove linecard reference counting Jiri Pirko
2023-01-08 15:50 ` Ido Schimmel
2023-01-09 8:42 ` Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 4/9] devlink: remove reporters_lock Jiri Pirko
2023-01-08 16:28 ` Ido Schimmel
2023-01-09 8:44 ` Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 5/9] devlink: remove reporter reference counting Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 6/9] devlink: convert linecards dump to devlink_nl_instance_iter_dump() Jiri Pirko
2023-01-08 17:01 ` Ido Schimmel [this message]
2023-01-07 10:11 ` [patch net-next v2 7/9] devlink: convert reporters " Jiri Pirko
2023-01-07 10:11 ` [patch net-next 8/8] devlink: add instance lock assertion in devl_is_registered() Jiri Pirko
2023-01-07 10:11 ` [patch net-next v2 8/9] devlink: remove devlink_dump_for_each_instance_get() helper Jiri Pirko
2023-01-07 10:26 ` [patch net-next v2 9/9] devlink: add instance lock assertion in devl_is_registered() Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7r3BQphwVLuaBZ/@shredder \
--to=idosch@nvidia$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox