Subject: Re: [PATCH net-next 06/10] nfp: fill IPsec state validation failure reason

From: Simon Horman <[email-masked]>
Date: Mon, 23 Jan 2023 16:09:20 +0100

On Mon, Jan 23, 2023 at 04:00:19PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <[email-masked]>
> 
> Rely on extack to return failure reason.
> 
> Signed-off-by: Leon Romanovsky <[email-masked]>
> Signed-off-by: Leon Romanovsky <[email-masked]>

One minor suggestion below, but regardless this looks good to me.

Reviewed-by: Simon Horman <[email-masked]>

> ---
>  .../net/ethernet/netronome/nfp/crypto/ipsec.c | 38 +++++++++----------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c b/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c
> index 41b98f2b7402..7af41cbc8c0b 100644
> --- a/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c
> +++ b/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c

...

>  	if (x->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) {
> -		nn_err(nn, "Unsupported xfrm offload tyoe\n");
> +		NL_SET_ERR_MSG_MOD(extack, "Unsupported xfrm offload tyoe");

While we are here, maybe s/tyoe/type/ ?

...