From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Marcin Wojtas <mw@semihalf•com>
Cc: linux-kernel@vger•kernel.org, linux-acpi@vger•kernel.org,
netdev@vger•kernel.org, rafael@kernel•org,
sean.wang@mediatek•com, Landen.Chao@mediatek•com,
linus.walleij@linaro•org, andrew@lunn•ch,
vivien.didelot@gmail•com, f.fainelli@gmail•com,
olteanv@gmail•com, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, linux@armlinux•org.uk,
hkallweit1@gmail•com, jaz@semihalf•com, tn@semihalf•com,
Samer.El-Haj-Mahmoud@arm•com
Subject: Re: [net-next: PATCH v4 5/8] device property: introduce fwnode_find_parent_dev_match
Date: Mon, 16 Jan 2023 20:00:19 +0200 [thread overview]
Message-ID: <Y8WQszCL6CicJSuU@smile.fi.intel.com> (raw)
In-Reply-To: <20230116173420.1278704-6-mw@semihalf.com>
On Mon, Jan 16, 2023 at 06:34:17PM +0100, Marcin Wojtas wrote:
> Add a new generic routine fwnode_find_parent_dev_match that can be used
> e.g. as a callback for class_find_device(). It searches for the struct
> device corresponding to a struct fwnode_handle by iterating over device
> and its parents.
If it helps you, I have no objections, hence
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
> Signed-off-by: Marcin Wojtas <mw@semihalf•com>
> ---
> include/linux/property.h | 1 +
> drivers/base/property.c | 23 ++++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 37179e3abad5..4ae20d7c5103 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -109,6 +109,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode);
> unsigned int fwnode_count_parents(const struct fwnode_handle *fwn);
> struct fwnode_handle *fwnode_get_nth_parent(struct fwnode_handle *fwn,
> unsigned int depth);
> +int fwnode_find_parent_dev_match(struct device *dev, const void *data);
> bool fwnode_is_ancestor_of(struct fwnode_handle *ancestor, struct fwnode_handle *child);
> struct fwnode_handle *fwnode_get_next_child_node(
> const struct fwnode_handle *fwnode, struct fwnode_handle *child);
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index bbb3e499ff4a..84849d4934cc 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -693,6 +693,29 @@ struct fwnode_handle *fwnode_get_nth_parent(struct fwnode_handle *fwnode,
> }
> EXPORT_SYMBOL_GPL(fwnode_get_nth_parent);
>
> +/**
> + * fwnode_find_parent_dev_match - look for a device matching the struct fwnode_handle
> + * @dev: the struct device to initiate the search
> + * @data: pointer passed for comparison
> + *
> + * Looks up the device structure corresponding with the fwnode by iterating
> + * over @dev and its parents.
> + * The routine can be used e.g. as a callback for class_find_device().
> + *
> + * Returns: %1 - match is found
> + * %0 - match not found
> + */
> +int fwnode_find_parent_dev_match(struct device *dev, const void *data)
> +{
> + for (; dev; dev = dev->parent) {
> + if (device_match_fwnode(dev, data))
> + return 1;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(fwnode_find_parent_dev_match);
> +
> /**
> * fwnode_is_ancestor_of - Test if @ancestor is ancestor of @child
> * @ancestor: Firmware which is tested for being an ancestor
> --
> 2.29.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-16 18:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 17:34 [net-next: PATCH v4 0/8] DSA: switch to fwnode_/device_ Marcin Wojtas
2023-01-16 17:34 ` [net-next: PATCH v4 1/8] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2023-01-16 17:34 ` [net-next: PATCH v4 2/8] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2023-01-16 17:50 ` Russell King (Oracle)
2023-01-16 18:16 ` Vladimir Oltean
2023-01-16 22:04 ` Andrew Lunn
2023-01-17 16:05 ` Marcin Wojtas
2023-01-17 16:34 ` Vladimir Oltean
2023-01-17 18:01 ` Marcin Wojtas
2023-01-18 0:38 ` Andrew Lunn
[not found] ` <CAPv3WKcbuY0kmM0trfS++at=r4KhCsp2bZ1kBL2r+-YJe=kE3w@mail.gmail.com>
2023-01-17 17:58 ` Russell King (Oracle)
2023-01-17 18:02 ` Marcin Wojtas
2023-01-16 22:13 ` Andrew Lunn
2023-01-17 14:08 ` Arun.Ramadoss
2023-01-16 17:34 ` [net-next: PATCH v4 3/8] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2023-01-16 17:34 ` [net-next: PATCH v4 4/8] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2023-01-16 18:01 ` Andy Shevchenko
2023-01-16 17:34 ` [net-next: PATCH v4 5/8] device property: introduce fwnode_find_parent_dev_match Marcin Wojtas
2023-01-16 18:00 ` Andy Shevchenko [this message]
2023-01-16 17:34 ` [net-next: PATCH v4 6/8] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2023-01-16 17:34 ` [net-next: PATCH v4 7/8] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2023-01-16 17:34 ` [net-next: PATCH v4 8/8] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8WQszCL6CicJSuU@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=Samer.El-Haj-Mahmoud@arm$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jaz@semihalf$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=sean.wang@mediatek$(echo .)com \
--cc=tn@semihalf$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox