From: Piergiorgio Beruto <piergiorgio.beruto@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
Oleksij Rempel <o.rempel@pengutronix•de>,
mailhol.vincent@wanadoo•fr, sudheer.mogilappagari@intel•com,
sbhatta@marvell•com, linux-doc@vger•kernel.org,
wangjie125@huawei•com, corbet@lwn•net, lkp@intel•com,
gal@nvidia•com, gustavoars@kernel•org, bagasdotme@gmail•com
Subject: Re: [PATCH net-next 1/1] drivers/phylib: fix coverity issue
Date: Wed, 18 Jan 2023 16:54:49 +0100 [thread overview]
Message-ID: <Y8gWSZr5XL3r02rm@gvm01> (raw)
In-Reply-To: <20230117192604.77a16822@kernel.org>
On Tue, Jan 17, 2023 at 07:26:04PM -0800, Jakub Kicinski wrote:
> On Tue, 17 Jan 2023 22:47:53 +0100 Piergiorgio Beruto wrote:
> > Subject: [PATCH net-next 1/1] drivers/phylib: fix coverity issue
>
> The title of the patch should refer to the bug rather than which tool
> found it.
>
> here, for eaxmple:
>
> net: phy: fix use of uninit variable when setting PLCA config
>
> > Coverity reported the following:
> >
> > *** CID 1530573: (UNINIT)
> > drivers/net/phy/phy-c45.c:1036 in genphy_c45_plca_set_cfg()
> > 1030 return ret;
> > 1031
> > 1032 val = ret;
> > 1033 }
> > 1034
> > 1035 if (plca_cfg->node_cnt >= 0)
> [snip]
> > Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail•com>
> > Reported-by: coverity-bot <keescook+coverity-bot@chromium•org>
> > Addresses-Coverity-ID: 1530573 ("UNINIT")
> > Fixes: 493323416fed ("drivers/net/phy: add helpers to get/set PLCA configuration")
>
> nit: the tags are in somewhat unnatural order. Since you'll need to
> respin for the subject change, this would be better:
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium•org>
> Fixes: 493323416fed ("drivers/net/phy: add helpers to get/set PLCA configuration")
> Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail•com>
>
> (Yes, the custom coverity tag can go meet its friends in the bin)
Thanks Jakub,
I just fixed that.
Kind Regards,
Piergiorgio
prev parent reply other threads:[~2023-01-18 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 21:47 [PATCH net-next 1/1] drivers/phylib: fix coverity issue Piergiorgio Beruto
2023-01-17 23:14 ` Jacob Keller
2023-01-18 3:26 ` Jakub Kicinski
2023-01-18 15:54 ` Piergiorgio Beruto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gWSZr5XL3r02rm@gvm01 \
--to=piergiorgio.beruto@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bagasdotme@gmail$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=lkp@intel$(echo .)com \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sudheer.mogilappagari@intel$(echo .)com \
--cc=wangjie125@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox