Subject: Re: [PATCH net-next 0/7] sfc: devlink support for ef100

From: Martin Habets <[email-masked]>
Date: Fri, 20 Jan 2023 08:55:01 +0000

Please fix my email address as per the MAINTAINTERS file:
 [email-masked]

On Thu, Jan 19, 2023 at 11:31:33AM +0000, [email-masked] wrote:
> From: Alejandro Lucero <[email-masked]>
> 
> This patchset adds devlink port support for ef100 allowing setting VFs
> mac addresses through the VF representors netdevs.
> 
> Basic devlink support is first introduced for info command. Then changes
> for enumerating MAE ports which will be used for devlik port creation

Typo: devlink.

> when netdevs are register.

.. are registered.

> 
> Adding support for devlink port_function_hw_addr_get requires changes in
> the ef100 driver for getting the mac address based on a client handle.
> This allows to obtain VFs mac address during netdev initialization as
> well what is included in patch 5.
> 
> Such client handle is used in patches 6 and 7 for getting and setting
> devlink ports addresses.

port in stead of ports.

Martin

> 
> Alejandro Lucero (7):
>   sfc: add devlink support for ef100
>   sfc: enumerate mports in ef100
>   sfc: add mport lookup based on driver's mport data
>   sfc: add devlink port support for ef100
>   sfc: obtain device mac address based on firmware handle for ef100
>   sfc: add support for port_function_hw_addr_get devlink in ef100
>   sfc: add support for devlink port_function_hw_addr_set in ef100
> 
>  drivers/net/ethernet/sfc/Kconfig        |   1 +
>  drivers/net/ethernet/sfc/Makefile       |   3 +-
>  drivers/net/ethernet/sfc/ef100_netdev.c |  20 +-
>  drivers/net/ethernet/sfc/ef100_nic.c    |  96 +++-
>  drivers/net/ethernet/sfc/ef100_nic.h    |   7 +
>  drivers/net/ethernet/sfc/ef100_rep.c    |  58 ++-
>  drivers/net/ethernet/sfc/ef100_rep.h    |   9 +
>  drivers/net/ethernet/sfc/efx_devlink.c  | 629 ++++++++++++++++++++++++
>  drivers/net/ethernet/sfc/efx_devlink.h  |  27 +
>  drivers/net/ethernet/sfc/mae.c          | 212 +++++++-
>  drivers/net/ethernet/sfc/mae.h          |  39 ++
>  drivers/net/ethernet/sfc/mcdi.c         |  72 +++
>  drivers/net/ethernet/sfc/mcdi.h         |  10 +
>  drivers/net/ethernet/sfc/net_driver.h   |   7 +
>  14 files changed, 1162 insertions(+), 28 deletions(-)
>  create mode 100644 drivers/net/ethernet/sfc/efx_devlink.c
>  create mode 100644 drivers/net/ethernet/sfc/efx_devlink.h
> 
> -- 
> 2.17.1