Subject: Re: [PATCH v5 net-next 5/5] net: wwan: t7xx: Devlink documentation

From: Bagas Sanjaya <[email-masked]>
Date: Sun, 22 Jan 2023 09:13:44 +0700

On Sat, Jan 21, 2023 at 07:03:58PM +0530, [email-masked] wrote:
> +Flash Commands
> +--------------
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file preloader_k6880v1_mdot2_datacard.bin component "preloader"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file loader_ext-verified.img component "loader_ext1"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file tee-verified.img component "tee1"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file lk-verified.img component "lk"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file spmfw-verified.img component "spmfw"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file sspm-verified.img component "sspm_1"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file mcupm-verified.img component "mcupm_1"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file dpm-verified.img component "dpm_1"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file boot-verified.img component "boot"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file root.squashfs component "rootfs"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file modem-verified.img component "md1img"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file dsp-verified.bin component "md1dsp"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file OP_OTA.img component "mcf1"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file OEM_OTA.img component "mcf2"
> +
> +::
> +
> +  $ devlink dev flash pci/0000:$bdf file DEV_OTA.img component "mcf3"

It seems like you didn't describe what ``devlink dev flash`` commands above
are doing, as I had requested from v3 review [1].

> +Coredump Collection
> +~~~~~~~~~~~~~~~~~~~
> +
> +::
> +
> +  $ devlink region new mr_dump
> +
> +::
> +
> +  $ devlink region read mr_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del mr_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +The userspace application uses these commands for obtaining the modem component
> +logs when device encounters an exception.

Individual command explanation please?

> +
> +Second Stage Bootloader dump
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +::
> +
> +  $ devlink region new lk_dump
> +
> +::
> +
> +  $ devlink region read lk_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del lk_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +In fastboot mode the userspace application uses these commands for obtaining the
> +current snapshot of second stage bootloader.

Individual command explanation please?

Hint: see any manpages to get sense of how to write the explanations. 

Thanks.

[1]: https://lore.kernel.org/linux-doc/[email-masked]/

-- 
An old man doll... just what I always wanted! - Clara