From: Lorenzo Bianconi <lorenzo@kernel•org>
To: Gerhard Engleder <gerhard@engleder-embedded•com>
Cc: bpf@vger•kernel.org, netdev@vger•kernel.org, ast@kernel•org,
daniel@iogearbox•net, andrii@kernel•org, davem@davemloft•net,
kuba@kernel•org, hawk@kernel•org, pabeni@redhat•com,
edumazet@google•com, toke@redhat•com, memxor@gmail•com,
alardam@gmail•com, saeedm@nvidia•com, anthony.l.nguyen@intel•com,
gospo@broadcom•com, vladimir.oltean@nxp•com, nbd@nbd•name,
john@phrozen•org, leon@kernel•org, simon.horman@corigine•com,
aelior@marvell•com, christophe.jaillet@wanadoo•fr,
ecree.xilinx@gmail•com, mst@redhat•com, bjorn@kernel•org,
magnus.karlsson@intel•com, maciej.fijalkowski@intel•com,
intel-wired-lan@lists•osuosl.org, lorenzo.bianconi@redhat•com,
martin.lau@linux•dev
Subject: Re: [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features
Date: Thu, 26 Jan 2023 23:00:13 +0100 [thread overview]
Message-ID: <Y9L37bVacFMYdqVv@lore-desk> (raw)
In-Reply-To: <28eedfd5-4444-112b-bfbc-1c7682385c88@engleder-embedded.com>
[-- Attachment #1: Type: text/plain, Size: 2703 bytes --]
> On 25.01.23 01:33, Lorenzo Bianconi wrote:
> > From: Marek Majtyka <alardam@gmail•com>
> >
> > A summary of the flags being set for various drivers is given below.
> > Note that XDP_F_REDIRECT_TARGET and XDP_F_FRAG_TARGET are features
> > that can be turned off and on at runtime. This means that these flags
> > may be set and unset under RTNL lock protection by the driver. Hence,
> > READ_ONCE must be used by code loading the flag value.
> >
> > Also, these flags are not used for synchronization against the availability
> > of XDP resources on a device. It is merely a hint, and hence the read
> > may race with the actual teardown of XDP resources on the device. This
> > may change in the future, e.g. operations taking a reference on the XDP
> > resources of the driver, and in turn inhibiting turning off this flag.
> > However, for now, it can only be used as a hint to check whether device
> > supports becoming a redirection target.
> >
> > Turn 'hw-offload' feature flag on for:
> > - netronome (nfp)
> > - netdevsim.
> >
> > Turn 'native' and 'zerocopy' features flags on for:
> > - intel (i40e, ice, ixgbe, igc)
> > - mellanox (mlx5).
> > - stmmac
> >
> > Turn 'native' features flags on for:
> > - amazon (ena)
> > - broadcom (bnxt)
> > - freescale (dpaa, dpaa2, enetc)
> > - funeth
> > - intel (igb)
> > - marvell (mvneta, mvpp2, octeontx2)
> > - mellanox (mlx4)
> > - qlogic (qede)
> > - sfc
> > - socionext (netsec)
> > - ti (cpsw)
> > - tap
> > - veth
> > - xen
> > - virtio_net.
> >
> > Turn 'basic' (tx, pass, aborted and drop) features flags on for:
> > - netronome (nfp)
> > - cavium (thunder)
> > - hyperv.
> >
> > Turn 'redirect_target' feature flag on for:
> > - amanzon (ena)
> > - broadcom (bnxt)
> > - freescale (dpaa, dpaa2)
> > - intel (i40e, ice, igb, ixgbe)
> > - ti (cpsw)
> > - marvell (mvneta, mvpp2)
> > - sfc
> > - socionext (netsec)
> > - qlogic (qede)
> > - mellanox (mlx5)
> > - tap
> > - veth
> > - virtio_net
> > - xen
>
> XDP support for tsnep was merged to net-next last week. So this driver
> cannot get XDP feature support in bpf-next as it is not there currently.
> Should I add these flags with a fix afterwards? Or would net-next be the
> better target for this patch series?
It is better to target this series to bpf-next I guess since there are some
libbpf and bpf changes.
I would say we can fix tsnep with a follow-up patch or I can add it to the
series if bpf-next will be rebased before the series is merged, it depends on
the upstream discussion.
Regards,
Lorenzo
>
> Gerhard
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-26 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 0:33 [PATCH v2 bpf-next 0/8] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 1/8] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-25 10:12 ` Jesper Dangaard Brouer
2023-01-25 0:33 ` [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-25 3:04 ` Jakub Kicinski
2023-01-25 4:00 ` kernel test robot
2023-01-25 8:27 ` Simon Horman
2023-01-26 19:09 ` Gerhard Engleder
2023-01-26 22:00 ` Lorenzo Bianconi [this message]
2023-01-29 13:05 ` Lorenzo Bianconi
2023-01-30 14:09 ` Gerhard Engleder
2023-01-25 0:33 ` [PATCH v2 bpf-next 3/8] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 4/8] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 5/8] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 6/8] bpf: devmap: check XDP features in __xdp_enqueue routine Lorenzo Bianconi
2023-01-25 10:35 ` Jesper Dangaard Brouer
2023-01-25 0:33 ` [PATCH v2 bpf-next 7/8] selftests/bpf: add test for bpf_xdp_query xdp-features support Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9L37bVacFMYdqVv@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=aelior@marvell$(echo .)com \
--cc=alardam@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gerhard@engleder-embedded$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=john@phrozen$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=memxor@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox