From: Martin Habets <habetsm.xilinx@gmail•com>
To: alejandro.lucero-palau@amd•com
Cc: netdev@vger•kernel.org, linux-net-drivers@amd•com,
davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, ecree.xilinx@gmail•com
Subject: Re: [PATCH v3 net-next 0/8] sfc: devlink support for ef100
Date: Fri, 27 Jan 2023 11:03:13 +0000 [thread overview]
Message-ID: <Y9Ovcc5jkiEVz0XC@gmail.com> (raw)
In-Reply-To: <20230127093651.54035-1-alejandro.lucero-palau@amd.com>
On Fri, Jan 27, 2023 at 09:36:43AM +0000, alejandro.lucero-palau@amd•com wrote:
> From: Alejandro Lucero <alejandro.lucero-palau@amd•com>
>
> v3 changes:
> - fix compilation warnings/errors reported by checkpatch
I hope you also fixed the modpost issue reported in
https://lore.kernel.org/netdev/202301251924.Vt4cZmeM-lkp@intel.com/
>
> v2 changes:
> - splitting up devlink info from basic devlink support
> - using devlink lock/unlock during initialization and removal
> - fix devlink registration order
> - splitting up efx_devlink_info_running_versions
> - Add sfc.rst with specifics about sfc info
> - embedding dl_port in mports
> - using extack for error reports to user space
>
> This patchset adds devlink port support for ef100 allowing setting VFs
> mac addresses through the VF representor devlink ports.
>
> Basic devlink infrastructure is first introduced, then support for info
> command. Next changes for enumerating MAE ports which will be used for
> devlik port creation when netdevs are registered.
Typo: devlik should be devlink.
>
> Adding support for devlink port_function_hw_addr_get requires changes in
> the ef100 driver for getting the mac address based on a client handle.
> This allows to obtain VFs mac address during netdev initialization as
> well what is included in patch 6.
>
> Such client handle is used in patches 7 and 8 for getting and setting
> devlink ports addresses.
port in stead of ports.
Martin
>
> Alejandro Lucero (8):
> sfc: add devlink support for ef100
> sfc: add devlink info support for ef100
> sfc: enumerate mports in ef100
> sfc: add mport lookup based on driver's mport data
> sfc: add devlink port support for ef100
> sfc: obtain device mac address based on firmware handle for ef100
> sfc: add support for devlink port_function_hw_addr_get in ef100
> sfc: add support for devlink port_function_hw_addr_set in ef100
>
> Documentation/networking/devlink/sfc.rst | 57 ++
> drivers/net/ethernet/sfc/Kconfig | 1 +
> drivers/net/ethernet/sfc/Makefile | 3 +-
> drivers/net/ethernet/sfc/ef100_netdev.c | 31 ++
> drivers/net/ethernet/sfc/ef100_nic.c | 93 +++-
> drivers/net/ethernet/sfc/ef100_nic.h | 7 +
> drivers/net/ethernet/sfc/ef100_rep.c | 57 +-
> drivers/net/ethernet/sfc/ef100_rep.h | 10 +
> drivers/net/ethernet/sfc/efx_devlink.c | 660 +++++++++++++++++++++++
> drivers/net/ethernet/sfc/efx_devlink.h | 46 ++
> drivers/net/ethernet/sfc/mae.c | 218 +++++++-
> drivers/net/ethernet/sfc/mae.h | 41 ++
> drivers/net/ethernet/sfc/mcdi.c | 72 +++
> drivers/net/ethernet/sfc/mcdi.h | 8 +
> drivers/net/ethernet/sfc/net_driver.h | 8 +
> 15 files changed, 1285 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/networking/devlink/sfc.rst
> create mode 100644 drivers/net/ethernet/sfc/efx_devlink.c
> create mode 100644 drivers/net/ethernet/sfc/efx_devlink.h
>
> --
> 2.17.1
prev parent reply other threads:[~2023-01-27 11:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 9:36 [PATCH v3 net-next 0/8] sfc: devlink support for ef100 alejandro.lucero-palau
2023-01-27 9:36 ` [PATCH v3 net-next 1/8] sfc: add " alejandro.lucero-palau
2023-01-27 9:36 ` [PATCH v3 net-next 2/8] sfc: add devlink info " alejandro.lucero-palau
2023-01-27 11:20 ` Martin Habets
2023-01-27 11:29 ` Lucero Palau, Alejandro
2023-01-27 12:26 ` Martin Habets
2023-01-27 11:31 ` Lucero Palau, Alejandro
2023-01-31 8:58 ` Lucero Palau, Alejandro
2023-01-31 12:05 ` Martin Habets
2023-01-31 14:00 ` Lucero Palau, Alejandro
2023-01-28 16:21 ` kernel test robot
2023-01-27 9:36 ` [PATCH v3 net-next 3/8] sfc: enumerate mports in ef100 alejandro.lucero-palau
2023-01-27 9:36 ` [PATCH v3 net-next 4/8] sfc: add mport lookup based on driver's mport data alejandro.lucero-palau
2023-01-27 9:36 ` [PATCH v3 net-next 5/8] sfc: add devlink port support for ef100 alejandro.lucero-palau
2023-01-27 11:35 ` Martin Habets
2023-01-31 9:36 ` Lucero Palau, Alejandro
2023-01-31 12:19 ` Martin Habets
2023-01-27 9:36 ` [PATCH v3 net-next 6/8] sfc: obtain device mac address based on firmware handle " alejandro.lucero-palau
2023-01-27 9:36 ` [PATCH v3 net-next 7/8] sfc: add support for devlink port_function_hw_addr_get in ef100 alejandro.lucero-palau
2023-01-27 11:51 ` Martin Habets
2023-01-31 9:40 ` Lucero Palau, Alejandro
2023-01-27 9:36 ` [PATCH v3 net-next 8/8] sfc: add support for devlink port_function_hw_addr_set " alejandro.lucero-palau
2023-01-27 11:03 ` Martin Habets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9Ovcc5jkiEVz0XC@gmail.com \
--to=habetsm.xilinx@gmail$(echo .)com \
--cc=alejandro.lucero-palau@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox