From: Lorenzo Bianconi <lorenzo@kernel•org>
To: Martin KaFai Lau <martin.lau@linux•dev>
Cc: bpf@vger•kernel.org, netdev@vger•kernel.org, ast@kernel•org,
daniel@iogearbox•net, andrii@kernel•org, davem@davemloft•net,
kuba@kernel•org, hawk@kernel•org, pabeni@redhat•com,
edumazet@google•com, toke@redhat•com, memxor@gmail•com,
alardam@gmail•com, saeedm@nvidia•com, anthony.l.nguyen@intel•com,
gospo@broadcom•com, vladimir.oltean@nxp•com, nbd@nbd•name,
john@phrozen•org, leon@kernel•org, simon.horman@corigine•com,
aelior@marvell•com, christophe.jaillet@wanadoo•fr,
ecree.xilinx@gmail•com, mst@redhat•com, bjorn@kernel•org,
magnus.karlsson@intel•com, maciej.fijalkowski@intel•com,
intel-wired-lan@lists•osuosl.org, lorenzo.bianconi@redhat•com,
sdf@google•com
Subject: Re: [PATCH v3 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool
Date: Fri, 27 Jan 2023 18:26:49 +0100 [thread overview]
Message-ID: <Y9QJWQvGKbSPK676@lore-desk> (raw)
In-Reply-To: <a208ed96-20e5-43d3-13e9-122776230da1@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
> On 1/26/23 10:36 AM, sdf@google•com wrote:
> >
> > > + sockfd = socket(AF_INET, SOCK_DGRAM, 0);
> > > + if (sockfd < 0) {
> > > + fprintf(stderr, "Failed to create echo socket\n");
> > > + return -errno;
> > > + }
> > > +
> > > + err = setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR, &optval,
> > > + sizeof(optval));
> > > + if (err < 0) {
> > > + fprintf(stderr, "Failed sockopt on echo socket\n");
> > > + return -errno;
> > > + }
> > > +
> > > + err = bind(sockfd, (struct sockaddr *)&addr, sizeof(addr));
> > > + if (err) {
> > > + fprintf(stderr, "Failed to bind echo socket\n");
> > > + return -errno;
> > > + }
> >
> > IIRC, Martin mentioned IPv6 support in the previous version. Should we
> > also make the userspace v6 aware by at least using AF_INET6 dualstack
> > sockets? I feel like listening on inaddr_any with AF_INET6 should
> > get us there without too much pain..
>
> Yeah. Think about host that only has IPv6 address. A tool not supporting
> IPv6 is a no-go nowadays.
ack, I will add it in v4.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-27 17:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 12:58 [PATCH v3 bpf-next 0/8] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 1/8] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 2/8] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-26 18:27 ` sdf
2023-01-26 12:58 ` [PATCH v3 bpf-next 3/8] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 4/8] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 5/8] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-27 23:38 ` Andrii Nakryiko
2023-01-28 12:48 ` Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 6/8] bpf: devmap: check XDP features in __xdp_enqueue routine Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 7/8] selftests/bpf: add test for bpf_xdp_query xdp-features support Lorenzo Bianconi
2023-01-26 18:28 ` sdf
2023-01-26 12:58 ` [PATCH v3 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
2023-01-26 18:36 ` sdf
2023-01-27 8:19 ` Martin KaFai Lau
2023-01-27 17:26 ` Lorenzo Bianconi [this message]
2023-01-27 17:26 ` Lorenzo Bianconi
2023-01-27 17:41 ` Stanislav Fomichev
2023-01-27 17:52 ` Toke Høiland-Jørgensen
2023-01-27 17:58 ` Lorenzo Bianconi
2023-01-27 17:59 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9QJWQvGKbSPK676@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=aelior@marvell$(echo .)com \
--cc=alardam@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=john@phrozen$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=memxor@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox