From: Simon Horman <simon.horman@corigine•com>
To: netdev@kapio-technology•com
Cc: davem@davemloft•net, kuba@kernel•org, netdev@vger•kernel.org,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Kurt Kanzenbach" <kurt@linutronix•de>,
"Hauke Mehrtens" <hauke@hauke-m•de>,
"Woojung Huh" <woojung.huh@microchip•com>,
"maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER"
<UNGLinuxDriver@microchip•com>,
"Sean Wang" <sean.wang@mediatek•com>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Clément Léger" <clement.leger@bootlin•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"Ivan Vecera" <ivecera@redhat•com>,
"Roopa Prabhu" <roopa@nvidia•com>,
"Nikolay Aleksandrov" <razor@blackwall•org>,
"Russell King" <linux@armlinux•org.uk>,
"Christian Marangi" <ansuelsmth@gmail•com>,
"open list" <linux-kernel@vger•kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists•infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists•infradead.org>,
"open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER"
<linux-renesas-soc@vger•kernel.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists•linux-foundation.org>
Subject: Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of dynamic ATU entries
Date: Fri, 3 Feb 2023 09:20:22 +0100 [thread overview]
Message-ID: <Y9zDxlwSn1EfCTba@corigine.com> (raw)
In-Reply-To: <9b12275969a204739ccfab972d90f20f@kapio-technology.com>
On Thu, Feb 02, 2023 at 06:00:00PM +0100, netdev@kapio-technology•com wrote:
> On 2023-01-31 19:56, Simon Horman wrote:
> > > --- a/drivers/net/dsa/mv88e6xxx/chip.c
> > > +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> > > @@ -42,6 +42,7 @@
> > > #include "ptp.h"
> > > #include "serdes.h"
> > > #include "smi.h"
> > > +#include "switchdev.h"
> > >
> > > static void assert_reg_lock(struct mv88e6xxx_chip *chip)
> > > {
> > > @@ -2726,18 +2727,25 @@ static int mv88e6xxx_port_fdb_add(struct
> > > dsa_switch *ds, int port,
> > > const unsigned char *addr, u16 vid,
> > > u16 fdb_flags, struct dsa_db db)
> > > {
> > > + bool is_dynamic = !!(fdb_flags & DSA_FDB_FLAG_DYNAMIC);
> > > struct mv88e6xxx_chip *chip = ds->priv;
> > > + u8 state;
> > > int err;
> > >
> > > - /* Ignore entries with flags set */
> > > - if (fdb_flags)
> > > - return 0;
> > > + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_STATIC;
> > > + if (is_dynamic)
> > > + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_AGE_7_NEWEST;
> >
> > What if flags other than DSA_FDB_FLAG_DYNAMIC are set (in future)?
>
> They will have to be caught and handled here if there is support for it,
> e.g. something like...
>
> else if (someflag)
> dosomething();
>
> For now only one flag will actually be set and they are mutually exclusive,
> as they will not make sense together with the potential flags I know, but
> that can change at some time of course.
Yes, I see that is workable. I do feel that checking for other flags would
be a bit more robust. But as you say, there are none. So whichever
approach you prefer is fine by me.
> >
> > > + else
> > > + if (fdb_flags)
> >
> > nit: else if (fdb_flags)
> >
> > > + return 0;
> > >
> >
> > ...
next prev parent reply other threads:[~2023-02-03 8:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 17:34 [PATCH net-next 0/5] ATU and FDB synchronization on locked ports Hans J. Schultz
2023-01-30 17:34 ` [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier Hans J. Schultz
2023-02-01 18:10 ` Ido Schimmel
2023-02-02 7:28 ` netdev
2023-02-02 16:11 ` Ido Schimmel
2023-02-02 16:38 ` netdev
2023-02-03 16:14 ` Ido Schimmel
2023-02-03 16:26 ` Vladimir Oltean
2023-02-03 16:27 ` netdev
2023-02-03 17:06 ` Ido Schimmel
2023-01-30 17:34 ` [PATCH net-next 2/5] net: dsa: propagate flags down towards drivers Hans J. Schultz
2023-01-30 17:34 ` [PATCH net-next 3/5] drivers: net: dsa: add fdb entry flags incoming to switchcore drivers Hans J. Schultz
2023-01-31 18:54 ` Simon Horman
2023-02-02 16:45 ` netdev
2023-02-03 8:17 ` Simon Horman
2023-02-03 18:41 ` netdev
2023-01-30 17:34 ` [PATCH net-next 4/5] net: bridge: ensure FDB offloaded flag is handled as needed Hans J. Schultz
2023-02-01 18:24 ` Ido Schimmel
2023-02-02 7:32 ` netdev
2023-01-30 17:34 ` [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of dynamic ATU entries Hans J. Schultz
2023-01-31 18:56 ` Simon Horman
2023-02-02 17:00 ` netdev
2023-02-03 8:20 ` Simon Horman [this message]
2023-02-03 20:44 ` Vladimir Oltean
2023-02-04 8:12 ` Simon Horman
2023-02-04 8:48 ` netdev
2023-02-06 16:02 ` Simon Horman
2023-02-14 21:14 ` Hans Schultz
2023-02-17 17:44 ` Vladimir Oltean
2023-02-20 14:11 ` Simon Horman
2023-01-31 19:25 ` [PATCH net-next 0/5] ATU and FDB synchronization on locked ports Ido Schimmel
2023-02-02 7:37 ` netdev
2023-02-02 15:43 ` Ido Schimmel
2023-02-02 16:19 ` netdev
2023-02-02 16:36 ` Ido Schimmel
2023-02-03 21:14 ` Vladimir Oltean
2023-02-02 17:18 ` netdev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9zDxlwSn1EfCTba@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=clement.leger@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=ivecera@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@kapio-technology$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox