From: Andrew Lunn <andrew@lunn•ch>
To: "Daniel González Cabanelas" <dgcbueu@gmail•com>
Cc: davem@davemloft•net, kuba@kernel•org, f.fainelli@gmail•com,
gregkh@linuxfoundation•org, netdev@vger•kernel.org,
noltari@gmail•com
Subject: Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment
Date: Thu, 25 Feb 2021 14:53:46 +0100 [thread overview]
Message-ID: <YDer6iWOd8bviNxb@lunn.ch> (raw)
In-Reply-To: <2323124.5UR7tLNZLG@tool>
On Wed, Feb 24, 2021 at 04:44:18PM +0100, Daniel González Cabanelas wrote:
> The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a
> result of this it works in polling mode.
>
> Fix it using the phy_device structure to assign the platform IRQ.
>
> Tested under a BCM6348 board. Kernel dmesg before the patch:
> Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY driver [Broadcom
> BCM63XX (1)] (mii_bus:phy_addr=bcm63xx_enet-0:01, irq=POLL)
>
> After the patch:
> Broadcom BCM63XX (1) bcm63xx_enet-0:01: attached PHY driver [Broadcom
> BCM63XX (1)] (mii_bus:phy_addr=bcm63xx_enet-0:01, irq=17)
>
> Pluging and uplugging the ethernet cable now generates interrupts and the
> PHY goes up and down as expected.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail•com>
> ---
> changes in V2:
> - snippet moved after the mdiobus registration
> - added missing brackets
Hi Daniel
It is a good idea to wait at least a day between posting versions. If
you post too frequently, people tend to review the old version, since
it is first in there mailbox.
Andrew
prev parent reply other threads:[~2021-02-25 13:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 15:44 [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment Daniel González Cabanelas
2021-02-24 21:44 ` Heiner Kallweit
2021-02-24 22:01 ` Florian Fainelli
2021-02-24 23:54 ` Daniel González Cabanelas
2021-02-25 7:22 ` Heiner Kallweit
2021-02-25 16:36 ` Daniel González Cabanelas
2021-02-25 20:05 ` Heiner Kallweit
2021-02-25 22:28 ` Daniel González Cabanelas
2021-02-25 22:56 ` Heiner Kallweit
2021-02-26 4:12 ` Florian Fainelli
2021-02-26 7:13 ` Heiner Kallweit
2021-02-26 9:10 ` Daniel González Cabanelas
2021-02-26 9:32 ` Heiner Kallweit
2021-02-26 9:38 ` Heiner Kallweit
2021-02-26 9:49 ` Daniel González Cabanelas
2021-02-26 10:08 ` Heiner Kallweit
2021-02-26 10:19 ` Daniel González Cabanelas
2021-02-26 14:16 ` Andrew Lunn
2021-02-26 14:28 ` Heiner Kallweit
2021-02-26 16:14 ` Daniel González Cabanelas
2021-02-26 16:55 ` Florian Fainelli
2021-02-25 13:53 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDer6iWOd8bviNxb@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dgcbueu@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=noltari@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox