From: Andrew Lunn <andrew@lunn•ch>
To: Joakim Zhang <qiangqing.zhang@nxp•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: FEC unbind/bind feature
Date: Fri, 26 Mar 2021 13:27:57 +0100 [thread overview]
Message-ID: <YF3TTZtJ1SLFkSpS@lunn.ch> (raw)
In-Reply-To: <DB8PR04MB679514359C626505E956981BE6619@DB8PR04MB6795.eurprd04.prod.outlook.com>
> > Please wrap your lines at around 75 characters. Standard netiquette rules for
> > emails apply to all Linux lists.
>
> Ok, thanks.
Please keep fighting with your email client,
> Yes, you are right. It should be always fine for single FEC controller, and unbind/bind one by one should also be fine for dual FEC controllers which share one MDIO bus. I test on i.MX6UL, i.MX8MM/MP.
> > > It seems to abstract an independent MDIO bus for dual FEC instances. I
> > > look at the MDIO dt bindings, it seems support such case as it has
> > > "reg"
> > > property. (Documentation/devicetree/bindings/net/mdio.yaml)
> >
> > You can have fully standalone MDIO bus drivers. You generally do this when the
> > MDIO bus registers are in their own address space, which you can ioremap()
> > separately from the MAC registers. Take a look in drivers/net/mdio/.
> >
> > > From your opinions, do you think it is necessary to improve it?
> >
> > What is you use case for unbinding/binding the FEC?
>
> Users may want to unbind FEC driver, and then bind to FEC UIO driver, such as for DPDK use case to improve the throughput.
You could blacklist the FEC driver so it never loads. Or change the
compatible string so it only matches the DPDK driver. Or use XDP :-)
Andrew
prev parent reply other threads:[~2021-03-26 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:04 FEC unbind/bind feature Joakim Zhang
2021-03-25 12:45 ` Andrew Lunn
2021-03-26 8:02 ` Joakim Zhang
2021-03-26 8:36 ` Joakim Zhang
2021-03-26 12:34 ` Andrew Lunn
2021-03-26 13:18 ` Joakim Zhang
2021-03-26 13:36 ` Andrew Lunn
2021-03-29 9:12 ` Joakim Zhang
2021-03-26 12:27 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF3TTZtJ1SLFkSpS@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=qiangqing.zhang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox