From: Andrew Lunn <andrew@lunn•ch>
To: Moshe Shemesh <moshe@nvidia•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Adrian Pop <pop.adrian61@gmail•com>,
Michal Kubecek <mkubecek@suse•cz>,
Don Bollinger <don@thebollingers•org>,
netdev@vger•kernel.org,
Vladyslav Tarasiuk <vladyslavt@nvidia•com>
Subject: Re: [RFC PATCH V4 net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data
Date: Tue, 23 Mar 2021 01:54:30 +0100 [thread overview]
Message-ID: <YFk8RldROAyivyuj@lunn.ch> (raw)
In-Reply-To: <1616433075-27051-2-git-send-email-moshe@nvidia.com>
> +static int eeprom_prepare_data(const struct ethnl_req_info *req_base,
> + struct ethnl_reply_data *reply_base,
> + struct genl_info *info)
> +{
> + struct eeprom_reply_data *reply = MODULE_EEPROM_REPDATA(reply_base);
> + struct eeprom_req_info *request = MODULE_EEPROM_REQINFO(req_base);
> + struct ethtool_module_eeprom page_data = {0};
> + struct net_device *dev = reply_base->dev;
> + int ret;
> +
> + if (!dev->ethtool_ops->get_module_eeprom_by_page)
> + return -EOPNOTSUPP;
> +
> + /* Allow dumps either of low or high page without crossing half page boundary */
> + if ((request->offset < ETH_MODULE_EEPROM_PAGE_LEN / 2 &&
> + request->offset + request->length > ETH_MODULE_EEPROM_PAGE_LEN / 2) ||
> + request->offset + request->length > ETH_MODULE_EEPROM_PAGE_LEN)
> + return -EINVAL;
Please keep all the parameter validation together, in
eeprom_parse_request(). At some point, we may extend
eeprom_parse_request() to make use of extack, to indicate which
parameter is invalid. Just getting an -EINVAL can be hard to debug,
where as NL_SET_ERR_MSG_ATTR() can help the user.
Andrew
next prev parent reply other threads:[~2021-03-23 0:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 17:11 [RFC PATCH V4 net-next 0/5] ethtool: Extend module EEPROM dump API Moshe Shemesh
2021-03-22 17:11 ` [RFC PATCH V4 net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data Moshe Shemesh
2021-03-22 18:17 ` Don Bollinger
2021-03-23 0:27 ` Andrew Lunn
2021-03-23 1:23 ` Don Bollinger
2021-03-23 2:03 ` Andrew Lunn
2021-03-23 17:47 ` Don Bollinger
2021-03-23 22:17 ` Andrew Lunn
2021-03-24 10:14 ` Moshe Shemesh
2021-03-24 10:03 ` Moshe Shemesh
2021-03-24 12:15 ` Andrew Lunn
2021-03-23 0:54 ` Andrew Lunn [this message]
2021-03-24 10:05 ` Moshe Shemesh
2021-03-22 17:11 ` [RFC PATCH V4 net-next 2/5] net/mlx5: Refactor module EEPROM query Moshe Shemesh
2021-03-22 17:11 ` [RFC PATCH V4 net-next 3/5] net/mlx5: Implement get_module_eeprom_by_page() Moshe Shemesh
2021-03-22 17:11 ` [RFC PATCH V4 net-next 4/5] net/mlx5: Add support for DSFP module EEPROM dumps Moshe Shemesh
2021-03-22 17:11 ` [RFC PATCH V4 net-next 5/5] ethtool: Add fallback to get_module_eeprom from netlink command Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFk8RldROAyivyuj@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=don@thebollingers$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=mkubecek@suse$(echo .)cz \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pop.adrian61@gmail$(echo .)com \
--cc=vladyslavt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox