From: Andrew Lunn <andrew@lunn•ch>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
ecree.xilinx@gmail•com, michael.chan@broadcom•com,
damian.dybek@intel•com, paul.greenwalt@intel•com,
rajur@chelsio•com, jaroslawx.gawin@intel•com,
vkochan@marvell•com, alobakin@pm•me, snelson@pensando•io,
shayagr@amazon•com, ayal@nvidia•com, shenjian15@huawei•com,
saeedm@nvidia•com, mkubecek@suse•cz, roopa@nvidia•com
Subject: Re: [PATCH net-next 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved
Date: Thu, 25 Mar 2021 13:22:47 +0100 [thread overview]
Message-ID: <YFyAl36ShF8mZbM8@lunn.ch> (raw)
In-Reply-To: <20210325011200.145818-4-kuba@kernel.org>
On Wed, Mar 24, 2021 at 06:11:57PM -0700, Jakub Kicinski wrote:
> struct ethtool_fecparam::reserved is never looked at by the core.
> Make sure it's actually 0. Unfortunately we can't return an error
> because old ethtool doesn't zero-initialize the structure for SET.
Hi Jakub
What makes it totally useless for future uses with SET. So the
documentation should probably be something like:
* @reserved: Reserved for future GET extensions.
*
* Older ethtool(1) leave @reserved uninitialised when calling SET or
* GET. Hence it can only be used to return a value to userspace with
* GET. Currently the value returned is guaranteed to be zero.
The rest looks O.K.
Andrew
next prev parent reply other threads:[~2021-03-25 12:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 1:11 [PATCH net-next 0/6] ethtool: clarify the ethtool FEC interface Jakub Kicinski
2021-03-25 1:11 ` [PATCH net-next 1/6] ethtool: fec: fix typo in kdoc Jakub Kicinski
2021-03-25 12:06 ` Andrew Lunn
2021-03-25 1:11 ` [PATCH net-next 2/6] ethtool: fec: remove long structure description Jakub Kicinski
2021-03-25 12:07 ` Andrew Lunn
2021-03-25 1:11 ` [PATCH net-next 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved Jakub Kicinski
2021-03-25 12:22 ` Andrew Lunn [this message]
2021-03-25 16:02 ` Jakub Kicinski
2021-03-25 1:11 ` [PATCH net-next 4/6] ethtool: fec: sanitize ethtool_fecparam->active_fec Jakub Kicinski
2021-03-25 12:25 ` Andrew Lunn
2021-03-25 1:11 ` [PATCH net-next 5/6] ethtool: fec: sanitize ethtool_fecparam->fec Jakub Kicinski
2021-03-25 12:00 ` Dan Carpenter
2021-03-25 16:03 ` Jakub Kicinski
2021-03-25 1:12 ` [PATCH net-next 6/6] ethtool: clarify the ethtool FEC interface Jakub Kicinski
2021-03-29 11:56 ` Edward Cree
2021-03-29 12:32 ` Andrew Lunn
2021-03-29 17:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFyAl36ShF8mZbM8@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alobakin@pm$(echo .)me \
--cc=ayal@nvidia$(echo .)com \
--cc=damian.dybek@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=jaroslawx.gawin@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.greenwalt@intel$(echo .)com \
--cc=rajur@chelsio$(echo .)com \
--cc=roopa@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=shenjian15@huawei$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=vkochan@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox