Subject: Re: [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang

From: Leon Romanovsky <[email-masked]>
Date: Wed, 21 Apr 2021 08:23:13 +0300

On Tue, Apr 20, 2021 at 03:24:19PM -0500, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping: who can take this, please?

Why don't you fix Clang instead?
Why do we have this churn for something that correct?

> 
> Thanks
> --
> Gustavo
> 
> On 3/5/21 02:48, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of just letting the code
> > fall through to the next case.
> > 
> > Link: https://github.com/KSPP/linux/issues/115
> > Reviewed-by: Tariq Toukan <[email-masked]>
> > Signed-off-by: Gustavo A. R. Silva <[email-masked]>
> > ---
> >  drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> > index a99e71bc7b3c..771b92019af1 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> > @@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,
> >  	case RES_XRCD:
> >  		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,
> >  				     vhcr->in_param, &vhcr->out_param);
> > +		break;
> >  
> >  	default:
> >  		break;
> >