From: Andrew Lunn <andrew@lunn•ch>
To: "Pali Rohár" <pali@kernel•org>
Cc: "Vivien Didelot" <vivien.didelot@gmail•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Vladimir Oltean" <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Marek Behún" <kabel@kernel•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches
Date: Mon, 12 Apr 2021 16:30:03 +0200 [thread overview]
Message-ID: <YHRZa9R22UyIRSd9@lunn.ch> (raw)
In-Reply-To: <20210412133447.fyqkavrs5r5wbino@pali>
> > > +/* This table contains representative model for every family */
> > > +static const enum mv88e6xxx_model family_model_table[] = {
> > > + [MV88E6XXX_FAMILY_6095] = MV88E6095,
> > > + [MV88E6XXX_FAMILY_6097] = MV88E6097,
> > > + [MV88E6XXX_FAMILY_6185] = MV88E6185,
> > > + [MV88E6XXX_FAMILY_6250] = MV88E6250,
> > > + [MV88E6XXX_FAMILY_6320] = MV88E6320,
> > > + [MV88E6XXX_FAMILY_6341] = MV88E6341,
> > > + [MV88E6XXX_FAMILY_6351] = MV88E6351,
> > > + [MV88E6XXX_FAMILY_6352] = MV88E6352,
> > > + [MV88E6XXX_FAMILY_6390] = MV88E6390,
> > > +};
> >
> > This table is wrong. MV88E6390 does not equal
> > MV88E6XXX_PORT_SWITCH_ID_PROD_6390. MV88E6XXX_PORT_SWITCH_ID_PROD_6390
> > was chosen because it is already an MDIO device ID, in register 2 and
> > 3. It probably will never clash with a real Marvell PHY ID. MV88E6390
> > is just a small integer, and there is a danger it will clash with a
> > real PHY.
>
> So... how to solve this issue? What should be in the mapping table?
You need to use MV88E6XXX_PORT_SWITCH_ID_PROD_6095,
MV88E6XXX_PORT_SWITCH_ID_PROD_6097,
...
MV88E6XXX_PORT_SWITCH_ID_PROD_6390,
> > You cannot just replace the MARVELL_PHY_ID_88E6390. That will break
> > the 6390! You need to add the new PHY for the 88E6341.
>
> I have not replaced anything.
Yes, sorry. I read the diff wrong.
Andrew
next prev parent reply other threads:[~2021-04-12 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:14 [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches Pali Rohár
2021-04-12 13:15 ` Andrew Lunn
2021-04-12 13:34 ` Pali Rohár
2021-04-12 14:30 ` Andrew Lunn [this message]
2021-04-12 14:39 ` Pali Rohár
2021-04-12 14:44 ` Andrew Lunn
2021-04-12 15:01 ` Pali Rohár
2021-04-12 15:32 ` Andrew Lunn
2021-04-12 15:52 ` Pali Rohár
2021-04-12 16:12 ` Andrew Lunn
2021-04-12 16:38 ` Pali Rohár
2021-04-12 23:45 ` Marek Behún
2021-04-12 16:57 ` [PATCH v2] " Pali Rohár
2021-04-12 17:44 ` Andrew Lunn
2021-04-12 21:30 ` patchwork-bot+netdevbpf
2021-04-12 23:25 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHRZa9R22UyIRSd9@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pali@kernel$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox