From: Ido Schimmel <idosch@idosch•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: mkubecek@suse•cz, netdev@vger•kernel.org,
Ido Schimmel <idosch@nvidia•com>
Subject: Re: [PATCH ethtool-next 7/7] netlink: stats: add on --all-groups option
Date: Thu, 22 Apr 2021 12:44:24 +0300 [thread overview]
Message-ID: <YIFFeDibFAmusGhM@shredder.lan> (raw)
In-Reply-To: <20210420003112.3175038-8-kuba@kernel.org>
On Mon, Apr 19, 2021 at 05:31:12PM -0700, Jakub Kicinski wrote:
> Add a switch for querying all statistic groups available
> in the kernel.
>
> To reject --groups and --all-groups being specified
> for one request add a concept of "parameter equivalency"
> in the parser. Alternative of having a special group
> type like "--groups all" seems less clean.
>
> Suggested-by: Ido Schimmel <idosch@nvidia•com>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Tested-by: Ido Schimmel <idosch@nvidia•com>
Thanks!
next prev parent reply other threads:[~2021-04-22 9:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 0:31 [PATCH ethtool-next 0/7] ethtool: support FEC and standard stats Jakub Kicinski
2021-04-20 0:31 ` [PATCH ethtool-next 1/7] update UAPI header copies Jakub Kicinski
2021-04-20 0:31 ` [PATCH ethtool-next 2/7] json: improve array print API Jakub Kicinski
2021-04-20 0:31 ` [PATCH ethtool-next 3/7] netlink: add FEC support Jakub Kicinski
2021-04-20 0:31 ` [PATCH ethtool-next 4/7] netlink: fec: support displaying statistics Jakub Kicinski
2021-04-20 0:31 ` [PATCH ethtool-next 5/7] ethtool: add nlchk for redirecting to netlink Jakub Kicinski
2021-04-20 0:31 ` [PATCH ethtool-next 6/7] netlink: add support for standard stats Jakub Kicinski
2021-04-22 9:41 ` Ido Schimmel
2021-04-20 0:31 ` [PATCH ethtool-next 7/7] netlink: stats: add on --all-groups option Jakub Kicinski
2021-04-22 9:44 ` Ido Schimmel [this message]
2021-04-22 8:49 ` [PATCH ethtool-next 0/7] ethtool: support FEC and standard stats Ido Schimmel
2021-04-22 15:34 ` Jakub Kicinski
2021-04-22 23:12 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIFFeDibFAmusGhM@shredder.lan \
--to=idosch@idosch$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox