From: Andrew Lunn <andrew@lunn•ch>
To: Wong Vee Khee <vee.khee.wong@linux•intel.com>
Cc: Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [RFC net-next 0/2] Introduce MDIO probe order C45 over C22
Date: Tue, 25 May 2021 15:34:34 +0200 [thread overview]
Message-ID: <YKz86iMwoP3VT4uh@lunn.ch> (raw)
In-Reply-To: <20210525055803.22116-1-vee.khee.wong@linux.intel.com>
On Tue, May 25, 2021 at 01:58:03PM +0800, Wong Vee Khee wrote:
> Synopsys MAC controller is capable of pairing with external PHY devices
> that accessible via Clause-22 and Clause-45.
>
> There is a problem when it is paired with Marvell 88E2110 which returns
> PHY ID of 0 using get_phy_c22_id(). We can add this check in that
> function, but this will break swphy, as swphy_reg_reg() return 0. [1]
Is it possible to identify it is a Marvell PHY? Do any of the other
C22 registers return anything unique? I'm wondering if adding
.match_phy_device to genphy would work to identify it is a Marvell PHY
and not bind to it. Or we can turn it around, make the
.match_phy_device specifically look for the fixed-link device by
putting a magic number in one of the vendor registers.
Andrew
next prev parent reply other threads:[~2021-05-25 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 5:58 [RFC net-next 0/2] Introduce MDIO probe order C45 over C22 Wong Vee Khee
2021-05-25 13:34 ` Andrew Lunn [this message]
2021-06-01 10:47 ` Wong Vee Khee
2021-06-01 13:04 ` Andrew Lunn
2021-06-01 15:44 ` Wong Vee Khee
2021-06-01 22:21 ` Andrew Lunn
2021-06-01 23:03 ` Wong Vee Khee
2021-06-02 2:19 ` Andrew Lunn
2021-06-02 14:15 ` Wong Vee Khee
2021-06-02 15:03 ` Andrew Lunn
2021-06-02 23:51 ` Wong Vee Khee
2021-06-05 0:37 ` Wong Vee Khee
2021-06-05 18:36 ` Andrew Lunn
2021-06-06 0:54 ` Wong Vee Khee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKz86iMwoP3VT4uh@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vee.khee.wong@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox