Subject: Re: [PATCH net-next v5] Add Mellanox BlueField Gigabit Ethernet driver

From: Andrew Lunn <[email-masked]>
Date: Sat, 29 May 2021 02:22:06 +0200

> +static void mlxbf_gige_adjust_link(struct net_device *netdev)
> +{
> +	struct mlxbf_gige *priv = netdev_priv(netdev);
> +	struct phy_device *phydev = netdev->phydev;
> +
> +	if (phydev->link) {
> +		priv->rx_pause = phydev->pause;
> +		priv->tx_pause = phydev->pause;
> +	}

...

> +	/* MAC supports symmetric flow control */
> +	phy_support_sym_pause(phydev);

What i don't see anywhere is you acting on the results of the pause
negotiation. It could be, mlxbf_gige_adjust_link() tells you the peer
does not support pause, and you need to disable it in this MAC as
well. It is a negotiation, after all.

	Andrew