From: Borislav Petkov <bp@alien8•de>
To: Tianyu Lan <ltykernel@gmail•com>
Cc: kys@microsoft•com, haiyangz@microsoft•com,
sthemmin@microsoft•com, wei.liu@kernel•org, decui@microsoft•com,
tglx@linutronix•de, mingo@redhat•com, x86@kernel•org,
hpa@zytor•com, arnd@arndb•de, dave.hansen@linux•intel.com,
luto@kernel•org, peterz@infradead•org, akpm@linux-foundation•org,
kirill.shutemov@linux•intel.com, rppt@kernel•org,
hannes@cmpxchg•org, cai@lca•pw, krish.sadhukhan@oracle•com,
saravanand@fb•com, Tianyu.Lan@microsoft•com,
konrad.wilk@oracle•com, hch@lst•de, m.szyprowski@samsung•com,
robin.murphy@arm•com, boris.ostrovsky@oracle•com,
jgross@suse•com, sstabellini@kernel•org, joro@8bytes•org,
will@kernel•org, xen-devel@lists•xenproject.org,
davem@davemloft•net, kuba@kernel•org, jejb@linux•ibm.com,
martin.petersen@oracle•com, iommu@lists•linux-foundation.org,
linux-arch@vger•kernel.org, linux-hyperv@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-scsi@vger•kernel.org,
netdev@vger•kernel.org, vkuznets@redhat•com,
thomas.lendacky@amd•com, brijesh.singh@amd•com,
sunilmut@microsoft•com
Subject: Re: [RFC PATCH V3 03/11] x86/Hyper-V: Add new hvcall guest address host visibility support
Date: Sun, 30 May 2021 20:25:47 +0200 [thread overview]
Message-ID: <YLPYqxF7urDIAd9z@zn.tnic> (raw)
In-Reply-To: <20210530150628.2063957-4-ltykernel@gmail.com>
On Sun, May 30, 2021 at 11:06:20AM -0400, Tianyu Lan wrote:
> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
> index 156cd235659f..a82975600107 100644
> --- a/arch/x86/mm/pat/set_memory.c
> +++ b/arch/x86/mm/pat/set_memory.c
> @@ -29,6 +29,8 @@
> #include <asm/proto.h>
> #include <asm/memtype.h>
> #include <asm/set_memory.h>
> +#include <asm/hyperv-tlfs.h>
> +#include <asm/mshyperv.h>
>
> #include "../mm_internal.h"
>
> @@ -1986,8 +1988,14 @@ static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
> int ret;
>
> /* Nothing to do if memory encryption is not active */
> - if (!mem_encrypt_active())
> + if (hv_is_isolation_supported()) {
> + return hv_set_mem_host_visibility((void *)addr,
> + numpages * HV_HYP_PAGE_SIZE,
> + enc ? VMBUS_PAGE_NOT_VISIBLE
> + : VMBUS_PAGE_VISIBLE_READ_WRITE);
Put all this gunk in a hv-specific function somewhere in hv-land which
you only call from here. This way you probably won't even need to export
hv_set_mem_host_visibility() and so on...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-05-30 18:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 15:06 [RFC PATCH V3 00/11] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 01/11] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-06-07 6:41 ` Christoph Hellwig
2021-06-07 8:14 ` Tianyu Lan
2021-06-09 12:38 ` Joerg Roedel
2021-06-10 14:13 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 02/11] x86/HV: Initialize shared memory boundary in the " Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 03/11] x86/Hyper-V: Add new hvcall guest address host visibility support Tianyu Lan
2021-05-30 18:25 ` Borislav Petkov [this message]
2021-05-31 4:08 ` Tianyu Lan
2021-06-10 9:47 ` Vitaly Kuznetsov
2021-06-10 14:18 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 04/11] HV: Add Write/Read MSR registers via ghcb Tianyu Lan
2021-06-09 12:46 ` Joerg Roedel
2021-06-10 14:15 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 05/11] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-06-09 12:49 ` Joerg Roedel
2021-05-30 15:06 ` [RFC PATCH V3 06/11] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 07/11] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 08/11] swiotlb: Add bounce buffer remap address setting function Tianyu Lan
2021-06-07 6:43 ` Christoph Hellwig
2021-06-07 14:56 ` Tianyu Lan
2021-06-10 14:25 ` Tianyu Lan
2021-06-14 7:12 ` Christoph Hellwig
2021-06-14 13:29 ` Tom Lendacky
2021-06-14 13:37 ` Tianyu Lan
2021-06-14 13:42 ` Tianyu Lan
2021-06-14 13:49 ` Robin Murphy
2021-06-14 15:32 ` Christoph Hellwig
2021-06-15 15:24 ` Tianyu Lan
2021-07-12 9:40 ` Tianyu Lan
2021-05-30 15:06 ` [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-06-02 1:16 ` Boris Ostrovsky
2021-06-02 15:01 ` Tianyu Lan
2021-06-02 16:02 ` Boris Ostrovsky
2021-06-03 15:37 ` Tianyu Lan
2021-06-03 17:04 ` Boris Ostrovsky
2021-06-07 6:44 ` Christoph Hellwig
2021-05-30 15:06 ` [RFC PATCH V3 10/11] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-06-07 6:50 ` Christoph Hellwig
2021-06-07 15:21 ` Tianyu Lan
2021-06-14 7:09 ` Christoph Hellwig
2021-06-14 14:04 ` Tianyu Lan
2021-06-14 15:33 ` Christoph Hellwig
2021-06-15 14:31 ` Tianyu Lan
2021-06-10 9:52 ` Vitaly Kuznetsov
2021-05-30 15:06 ` [RFC PATCH V3 11/11] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-06-07 6:46 ` Christoph Hellwig
2021-06-07 14:59 ` Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLPYqxF7urDIAd9z@zn.tnic \
--to=bp@alien8$(echo .)de \
--cc=Tianyu.Lan@microsoft$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=brijesh.singh@amd$(echo .)com \
--cc=cai@lca$(echo .)pw \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hannes@cmpxchg$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=hpa@zytor$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jgross@suse$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=krish.sadhukhan@oracle$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=ltykernel@gmail$(echo .)com \
--cc=luto@kernel$(echo .)org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=saravanand@fb$(echo .)com \
--cc=sstabellini@kernel$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
--cc=sunilmut@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox