From: Andrew Lunn <andrew@lunn•ch>
To: Zhou Yanjie <zhouyanjie@wanyeetech•com>
Cc: davem@davemloft•net, kuba@kernel•org, robh+dt@kernel•org,
peppe.cavallaro@st•com, alexandre.torgue@foss•st.com,
joabreu@synopsys•com, mcoquelin.stm32@gmail•com,
linux-mips@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, dongsheng.qiu@ingenic•com,
aric.pzqi@ingenic•com, rick.tyliu@ingenic•com,
sihui.liu@ingenic•com, jun.jiang@ingenic•com,
sernia.zhou@foxmail•com, paul@crapouillou•net
Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.
Date: Thu, 10 Jun 2021 16:42:24 +0200 [thread overview]
Message-ID: <YMIk0NfOPryoY607@lunn.ch> (raw)
In-Reply-To: <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com>
> We are much more strict about this now than before. You have to use
> standard units and convert to hardware values. It also makes it a lot
> easier for DT writers, if they have an idea what the units mean.
>
> Having the MAC add small delays is something you can add later,
> without breaking backwards compatibility. So if you cannot determine
> what the units are now, just submit the glue driver without support
> for this feature. If anybody really needs it, they can do the needed
> research, maybe do some measurements, and then add the code.
>
>
> I did an experiment, when the tx delay is not set, RGMII works a
You had rgmii-id in your device tree, so that the PHY added the
delays?
Andrew
next prev parent reply other threads:[~2021-06-10 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 17:35 [PATCH v2 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` [PATCH v2 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-09 17:35 ` [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-10 3:19 ` Andrew Lunn
2021-06-10 8:00 ` Zhou Yanjie
2021-06-10 12:15 ` Andrew Lunn
[not found] ` <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com>
2021-06-10 14:42 ` Andrew Lunn [this message]
2021-06-13 8:26 ` 周琰杰
[not found] ` <12f35415-532e-5514-bc97-683fb9655091@wanyeetech.com>
2021-06-10 14:57 ` Andrew Lunn
2021-06-13 8:34 ` 周琰杰
2021-06-13 16:31 ` Andrew Lunn
2021-06-14 15:57 ` 周琰杰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMIk0NfOPryoY607@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=aric.pzqi@ingenic$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dongsheng.qiu@ingenic$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=jun.jiang@ingenic$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul@crapouillou$(echo .)net \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=rick.tyliu@ingenic$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sernia.zhou@foxmail$(echo .)com \
--cc=sihui.liu@ingenic$(echo .)com \
--cc=zhouyanjie@wanyeetech$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox