From: Andrew Lunn <andrew@lunn•ch>
To: Weihang Li <liweihang@huawei•com>
Cc: davem@davemloft•net, kuba@kernel•org, hkallweit1@gmail•com,
netdev@vger•kernel.org, linuxarm@huawei•com,
Wenpeng Liang <liangwenpeng@huawei•com>
Subject: Re: [PATCH net-next 6/8] net: phy: print the function name by __func__ instead of an fixed string
Date: Fri, 11 Jun 2021 18:05:02 +0200 [thread overview]
Message-ID: <YMOJrv0ZRGCP26F7@lunn.ch> (raw)
In-Reply-To: <1623393419-2521-7-git-send-email-liweihang@huawei.com>
On Fri, Jun 11, 2021 at 02:36:57PM +0800, Weihang Li wrote:
> From: Wenpeng Liang <liangwenpeng@huawei•com>
>
> It's better to use __func__ than a fixed string to print a
> function's name.
>
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei•com>
> Signed-off-by: Weihang Li <liweihang@huawei•com>
> ---
> drivers/net/phy/mdio_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c
> index 0837319..c94cb53 100644
> --- a/drivers/net/phy/mdio_device.c
> +++ b/drivers/net/phy/mdio_device.c
> @@ -77,7 +77,7 @@ int mdio_device_register(struct mdio_device *mdiodev)
> {
> int err;
>
> - dev_dbg(&mdiodev->dev, "mdio_device_register\n");
> + dev_dbg(&mdiodev->dev, "%s\n", __func__);
>
> err = mdiobus_register_device(mdiodev);
> if (err)
> @@ -188,7 +188,7 @@ int mdio_driver_register(struct mdio_driver *drv)
> struct mdio_driver_common *mdiodrv = &drv->mdiodrv;
> int retval;
>
> - pr_debug("mdio_driver_register: %s\n", mdiodrv->driver.name);
> + pr_debug("%s: %s\n", __func__, mdiodrv->driver.name);
It would be nice to make this
dev_dbg(&mdiodev->dev, "%s: %s\n", __func__, mdiodrv->driver.name);
Andrew
next prev parent reply other threads:[~2021-06-11 16:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 6:36 [PATCH net-next 0/8] net: phy: fix some coding-style issues Weihang Li
2021-06-11 6:36 ` [PATCH net-next 1/8] net: phy: add a blank line after declarations Weihang Li
2021-06-11 14:31 ` Andrew Lunn
2021-06-15 6:12 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 2/8] net: phy: correct format of block comments Weihang Li
2021-06-11 14:36 ` Andrew Lunn
2021-06-15 6:18 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 3/8] net: phy: delete repeated word " Weihang Li
2021-06-11 14:39 ` Andrew Lunn
2021-06-15 6:21 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 4/8] net: phy: fixed formatting issues with braces Weihang Li
2021-06-11 14:41 ` Andrew Lunn
2021-06-16 6:39 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 5/8] net: phy: fixed space alignment issues Weihang Li
2021-06-11 15:30 ` Andrew Lunn
2021-06-15 6:24 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 6/8] net: phy: print the function name by __func__ instead of an fixed string Weihang Li
2021-06-11 16:05 ` Andrew Lunn [this message]
2021-06-15 6:26 ` liweihang
2021-06-16 8:14 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 7/8] net: phy: remove unnecessary line continuation Weihang Li
2021-06-11 16:06 ` Andrew Lunn
2021-06-15 6:26 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 8/8] net: phy: use '__packed' instead of '__attribute__((__packed__))' Weihang Li
2021-06-11 16:07 ` Andrew Lunn
2021-06-14 14:28 ` David Laight
2021-06-16 6:17 ` liweihang
2021-06-16 8:47 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMOJrv0ZRGCP26F7@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=liangwenpeng@huawei$(echo .)com \
--cc=linuxarm@huawei$(echo .)com \
--cc=liweihang@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox