Subject: Re: [PATCH V5 16/16] net: iosm: infrastructure

From: Leon Romanovsky <[email-masked]>
Date: Sun, 13 Jun 2021 19:01:09 +0300

On Sun, Jun 13, 2021 at 06:20:23PM +0530, M Chetan Kumar wrote:
> 1) Kconfig & Makefile changes for IOSM Driver compilation.
> 2) Add IOSM Driver documentation.
> 3) Modified MAINTAINER file for IOSM Driver addition.
> 
> Signed-off-by: M Chetan Kumar <[email-masked]>
> ---
> v5: Update mbim port name in doc to wwan0mbim0.
> v4: Adapt to wwan subsystem rtnet_link framework.
> v3:
> * Clean-up driver/net Kconfig & Makefile (Changes available as
>   part of wwan subsystem).
> * Removed NET dependency key word from iosm Kconfig.
> * Removed IOCTL section from documentation.
> v2:
> * Moved driver documentation to RsT file.
> * Modified if_link.h file to support link type iosm.
> ---
>  .../networking/device_drivers/index.rst       |  1 +
>  .../networking/device_drivers/wwan/index.rst  | 18 ++++
>  .../networking/device_drivers/wwan/iosm.rst   | 96 +++++++++++++++++++
>  MAINTAINERS                                   |  7 ++
>  drivers/net/wwan/Kconfig                      | 12 +++
>  drivers/net/wwan/Makefile                     |  1 +
>  drivers/net/wwan/iosm/Makefile                | 26 +++++
>  7 files changed, 161 insertions(+)
>  create mode 100644 Documentation/networking/device_drivers/wwan/index.rst
>  create mode 100644 Documentation/networking/device_drivers/wwan/iosm.rst
>  create mode 100644 drivers/net/wwan/iosm/Makefile

<...>

> +obj-$(CONFIG_IOSM) += iosm/
> diff --git a/drivers/net/wwan/iosm/Makefile b/drivers/net/wwan/iosm/Makefile
> new file mode 100644
> index 000000000000..cdeeb9357af6
> --- /dev/null
> +++ b/drivers/net/wwan/iosm/Makefile
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: (GPL-2.0-only)
> +#
> +# Copyright (C) 2020-21 Intel Corporation.
> +#
> +
> +iosm-y = \
> +	iosm_ipc_task_queue.o	\
> +	iosm_ipc_imem.o			\
> +	iosm_ipc_imem_ops.o		\
> +	iosm_ipc_mmio.o			\
> +	iosm_ipc_port.o			\
> +	iosm_ipc_wwan.o			\
> +	iosm_ipc_uevent.o		\
> +	iosm_ipc_pm.o			\
> +	iosm_ipc_pcie.o			\
> +	iosm_ipc_irq.o			\
> +	iosm_ipc_chnl_cfg.o		\
> +	iosm_ipc_protocol.o		\
> +	iosm_ipc_protocol_ops.o	\
> +	iosm_ipc_mux.o			\
> +	iosm_ipc_mux_codec.o
> +
> +obj-$(CONFIG_IOSM) := iosm.o
> +
> +# compilation flags
> +ccflags-y += -DDEBUG

Please no, default kernel code should be in release quality.

Thanks

> -- 
> 2.25.1