From: Leon Romanovsky <leon@kernel•org>
To: Nitesh Narayan Lal <nitesh@redhat•com>
Cc: linux-kernel@vger•kernel.org, linux-scsi@vger•kernel.org,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
linux-api@vger•kernel.org, linux-pci@vger•kernel.org,
tglx@linutronix•de, jesse.brandeburg@intel•com,
robin.murphy@arm•com, mtosatti@redhat•com, mingo@kernel•org,
jbrandeb@kernel•org, frederic@kernel•org, juri.lelli@redhat•com,
abelits@marvell•com, bhelgaas@google•com, rostedt@goodmis•org,
peterz@infradead•org, davem@davemloft•net,
akpm@linux-foundation•org, sfr@canb•auug.org.au,
stephen@networkplumber•org, rppt@linux•vnet.ibm.com,
chris.friesen@windriver•com, maz@kernel•org,
nhorman@tuxdriver•com, pjwaskiewicz@gmail•com,
sassmann@redhat•com, thenzl@redhat•com,
kashyap.desai@broadcom•com, sumit.saxena@broadcom•com,
shivasharan.srikanteshwara@broadcom•com,
sathya.prakash@broadcom•com, sreekanth.reddy@broadcom•com,
suganath-prabu.subramani@broadcom•com, james.smart@broadcom•com,
dick.kennedy@broadcom•com, jkc@redhat•com,
faisal.latif@intel•com, shiraz.saleem@intel•com,
tariqt@nvidia•com, ahleihel@redhat•com, kheib@redhat•com,
borisp@nvidia•com, saeedm@nvidia•com, benve@cisco•com,
govind@gmx•com, jassisinghbrar@gmail•com, luobin9@huawei•com,
ajit.khaparde@broadcom•com, sriharsha.basavapatna@broadcom•com,
somnath.kotur@broadcom•com, nilal@redhat•com
Subject: Re: [PATCH v1 14/14] net/mlx4: Use irq_update_affinity_hint
Date: Mon, 21 Jun 2021 11:01:06 +0300 [thread overview]
Message-ID: <YNBHQvo1uDfBbr5c@unreal> (raw)
In-Reply-To: <20210617182242.8637-15-nitesh@redhat.com>
On Thu, Jun 17, 2021 at 02:22:42PM -0400, Nitesh Narayan Lal wrote:
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask
> that is consumed by the userspace to distribute the interrupts. However,
> under the hood irq_set_affinity_hint() also applies the provided cpumask
> (if not NULL) as the affinity for the given interrupt which is an
> undocumented side effect.
>
> To remove this side effect irq_set_affinity_hint() has been marked
> as deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
> that only updates the affinity_hint pointer.
>
> Signed-off-by: Nitesh Narayan Lal <nitesh@redhat•com>
> ---
> drivers/net/ethernet/mellanox/mlx4/eq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
> index 9e48509ed3b2..f549d697ca95 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/eq.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
> @@ -244,9 +244,9 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec)
> cpumask_empty(eq->affinity_mask))
> return;
>
> - hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask);
> + hint_err = irq_update_affinity_hint(eq->irq, eq->affinity_mask);
> if (hint_err)
> - mlx4_warn(dev, "irq_set_affinity_hint failed, err %d\n", hint_err);
> + mlx4_warn(dev, "irq_update_affinity_hint failed, err %d\n", hint_err);
> }
> #endif
>
> @@ -1124,7 +1124,7 @@ static void mlx4_free_irqs(struct mlx4_dev *dev)
> if (eq_table->eq[i].have_irq) {
> free_cpumask_var(eq_table->eq[i].affinity_mask);
> #if defined(CONFIG_SMP)
> - irq_set_affinity_hint(eq_table->eq[i].irq, NULL);
> + irq_update_affinity_hint(eq_table->eq[i].irq, NULL);
> #endif
This #if/endif can be deleted.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia•com>
next prev parent reply other threads:[~2021-06-21 8:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 18:22 [PATCH v1 00/14] genirq: Cleanup the usage of irq_set_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-06-25 17:52 ` Nitesh Lal
2021-06-17 18:22 ` [PATCH v1 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 03/14] i40e: " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-06-17 19:31 ` Robin Murphy
2021-06-17 19:34 ` Nitesh Lal
2021-06-17 18:22 ` [PATCH v1 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 06/14] RDMA/i40iw: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 07/14] enic: " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 08/14] be2net: " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 09/14] ixgbe: " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 10/14] mailbox: " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 13/14] net/mlx5: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-21 8:01 ` Leon Romanovsky
2021-06-17 18:22 ` [PATCH v1 14/14] net/mlx4: " Nitesh Narayan Lal
2021-06-21 8:01 ` Leon Romanovsky [this message]
2021-06-21 12:59 ` Nitesh Lal
2021-06-25 21:08 ` Nitesh Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNBHQvo1uDfBbr5c@unreal \
--to=leon@kernel$(echo .)org \
--cc=abelits@marvell$(echo .)com \
--cc=ahleihel@redhat$(echo .)com \
--cc=ajit.khaparde@broadcom$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=benve@cisco$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=borisp@nvidia$(echo .)com \
--cc=chris.friesen@windriver$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dick.kennedy@broadcom$(echo .)com \
--cc=faisal.latif@intel$(echo .)com \
--cc=frederic@kernel$(echo .)org \
--cc=govind@gmx$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=james.smart@broadcom$(echo .)com \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=jbrandeb@kernel$(echo .)org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jkc@redhat$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kashyap.desai@broadcom$(echo .)com \
--cc=kheib@redhat$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=luobin9@huawei$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mingo@kernel$(echo .)org \
--cc=mtosatti@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nilal@redhat$(echo .)com \
--cc=nitesh@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pjwaskiewicz@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
--cc=sathya.prakash@broadcom$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=shiraz.saleem@intel$(echo .)com \
--cc=shivasharan.srikanteshwara@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
--cc=sreekanth.reddy@broadcom$(echo .)com \
--cc=sriharsha.basavapatna@broadcom$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=suganath-prabu.subramani@broadcom$(echo .)com \
--cc=sumit.saxena@broadcom$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thenzl@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox