From: Leon Romanovsky <leonro@nvidia•com>
To: Nitesh Narayan Lal <nitesh@redhat•com>
Cc: <linux-kernel@vger•kernel.org>, <linux-scsi@vger•kernel.org>,
<intel-wired-lan@lists•osuosl.org>, <netdev@vger•kernel.org>,
<linux-api@vger•kernel.org>, <linux-pci@vger•kernel.org>,
<tglx@linutronix•de>, <jesse.brandeburg@intel•com>,
<robin.murphy@arm•com>, <mtosatti@redhat•com>, <mingo@kernel•org>,
<jbrandeb@kernel•org>, <frederic@kernel•org>,
<juri.lelli@redhat•com>, <abelits@marvell•com>,
<bhelgaas@google•com>, <rostedt@goodmis•org>,
<peterz@infradead•org>, <davem@davemloft•net>,
<akpm@linux-foundation•org>, <sfr@canb•auug.org.au>,
<stephen@networkplumber•org>, <rppt@linux•vnet.ibm.com>,
<chris.friesen@windriver•com>, <maz@kernel•org>,
<nhorman@tuxdriver•com>, <pjwaskiewicz@gmail•com>,
<sassmann@redhat•com>, <thenzl@redhat•com>,
<kashyap.desai@broadcom•com>, <sumit.saxena@broadcom•com>,
<shivasharan.srikanteshwara@broadcom•com>,
<sathya.prakash@broadcom•com>, <sreekanth.reddy@broadcom•com>,
<suganath-prabu.subramani@broadcom•com>,
<james.smart@broadcom•com>, <dick.kennedy@broadcom•com>,
<jkc@redhat•com>, <faisal.latif@intel•com>,
<shiraz.saleem@intel•com>, <tariqt@nvidia•com>,
<ahleihel@redhat•com>, <kheib@redhat•com>, <borisp@nvidia•com>,
<saeedm@nvidia•com>, <benve@cisco•com>, <govind@gmx•com>,
<jassisinghbrar@gmail•com>, <ajit.khaparde@broadcom•com>,
<sriharsha.basavapatna@broadcom•com>,
<somnath.kotur@broadcom•com>, <nilal@redhat•com>,
<tatyana.e.nikolova@intel•com>, <mustafa.ismail@intel•com>,
<ahs3@redhat•com>, <chandrakanth.patil@broadcom•com>
Subject: Re: [PATCH v3 13/14] net/mlx5: Use irq_set_affinity_and_hint
Date: Wed, 14 Jul 2021 15:01:11 +0300 [thread overview]
Message-ID: <YO7SB4q9Q7S0lIbR@unreal> (raw)
In-Reply-To: <20210713211502.464259-14-nitesh@redhat.com>
On Tue, Jul 13, 2021 at 05:15:01PM -0400, Nitesh Narayan Lal wrote:
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask
> that is consumed by the userspace to distribute the interrupts and to apply
> the provided mask as the affinity for the mlx5 interrupts. However,
> irq_set_affinity_hint() applying the provided cpumask as an affinity for
> the interrupt is an undocumented side effect.
>
> To remove this side effect irq_set_affinity_hint() has been marked
> as deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
> where the provided mask needs to be applied as the affinity and
> affinity_hint pointer needs to be set and replace with
> irq_update_affinity_hint() where only affinity_hint needs to be updated.
>
> Signed-off-by: Nitesh Narayan Lal <nitesh@redhat•com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia•com>
next prev parent reply other threads:[~2021-07-14 12:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 21:14 [PATCH v3 00/14] genirq: Cleanup the usage of irq_set_affinity_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-13 21:51 ` Jesse Brandeburg
2021-07-13 21:14 ` [PATCH v3 03/14] i40e: " Nitesh Narayan Lal
2021-07-13 21:52 ` Jesse Brandeburg
2021-07-13 21:14 ` [PATCH v3 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 06/14] RDMA/irdma: " Nitesh Narayan Lal
2021-07-14 12:03 ` Leon Romanovsky
2021-07-14 12:56 ` Nitesh Lal
2021-07-14 13:02 ` Leon Romanovsky
2021-07-15 13:25 ` Nitesh Lal
2021-07-13 21:14 ` [PATCH v3 07/14] enic: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 08/14] be2net: " Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 09/14] ixgbe: " Nitesh Narayan Lal
2021-07-13 22:01 ` Jesse Brandeburg
2021-07-13 21:14 ` [PATCH v3 10/14] mailbox: " Nitesh Narayan Lal
2021-07-13 21:14 ` [PATCH v3 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-07-13 21:15 ` [PATCH v3 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-07-13 21:15 ` [PATCH v3 13/14] net/mlx5: " Nitesh Narayan Lal
2021-07-14 12:01 ` Leon Romanovsky [this message]
2021-07-13 21:15 ` [PATCH v3 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-07-14 11:19 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO7SB4q9Q7S0lIbR@unreal \
--to=leonro@nvidia$(echo .)com \
--cc=abelits@marvell$(echo .)com \
--cc=ahleihel@redhat$(echo .)com \
--cc=ahs3@redhat$(echo .)com \
--cc=ajit.khaparde@broadcom$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=benve@cisco$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=borisp@nvidia$(echo .)com \
--cc=chandrakanth.patil@broadcom$(echo .)com \
--cc=chris.friesen@windriver$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dick.kennedy@broadcom$(echo .)com \
--cc=faisal.latif@intel$(echo .)com \
--cc=frederic@kernel$(echo .)org \
--cc=govind@gmx$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=james.smart@broadcom$(echo .)com \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=jbrandeb@kernel$(echo .)org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jkc@redhat$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kashyap.desai@broadcom$(echo .)com \
--cc=kheib@redhat$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=mingo@kernel$(echo .)org \
--cc=mtosatti@redhat$(echo .)com \
--cc=mustafa.ismail@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nilal@redhat$(echo .)com \
--cc=nitesh@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pjwaskiewicz@gmail$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
--cc=sathya.prakash@broadcom$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=shiraz.saleem@intel$(echo .)com \
--cc=shivasharan.srikanteshwara@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
--cc=sreekanth.reddy@broadcom$(echo .)com \
--cc=sriharsha.basavapatna@broadcom$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=suganath-prabu.subramani@broadcom$(echo .)com \
--cc=sumit.saxena@broadcom$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=tatyana.e.nikolova@intel$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thenzl@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox