From: William Breathitt Gray <vilhelm.gray@gmail•com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
kernel@pengutronix•de, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-mips@vger•kernel.org,
linux-parisc@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-acpi@vger•kernel.org, linux-wireless@vger•kernel.org,
linux-sunxi@lists•linux.dev, linux-cxl@vger•kernel.org,
nvdimm@lists•linux.dev, dmaengine@vger•kernel.org,
linux1394-devel@lists•sourceforge.net,
linux-fpga@vger•kernel.org, linux-input@vger•kernel.org,
linux-hyperv@vger•kernel.org, linux-i2c@vger•kernel.org,
linux-i3c@lists•infradead.org,
industrypack-devel@lists•sourceforge.net,
linux-media@vger•kernel.org, linux-mmc@vger•kernel.org,
netdev@vger•kernel.org, linux-ntb@googlegroups•com,
linux-pci@vger•kernel.org, platform-driver-x86@vger•kernel.org,
linux-remoteproc@vger•kernel.org, linux-scsi@vger•kernel.org,
alsa-devel@alsa-project•org, linux-arm-msm@vger•kernel.org,
linux-spi@vger•kernel.org, linux-staging@lists•linux.dev,
greybus-dev@lists•linaro.org, target-devel@vger•kernel.org,
linux-usb@vger•kernel.org, linux-serial@vger•kernel.org,
virtualization@lists•linux-foundation.org, kvm@vger•kernel.org,
xen-devel@lists•xenproject.org
Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void
Date: Wed, 7 Jul 2021 06:37:39 +0900 [thread overview]
Message-ID: <YOTMp88HfFiy6+RM@shinobu> (raw)
In-Reply-To: <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2115 bytes --]
On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>
> Acked-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <broonie@kernel•org>
> Acked-by: Chen-Yu Tsai <wens@csie•org> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <pali@kernel•org>
> Acked-by: Mauro Carvalho Chehab <mchehab@kernel•org> (for drivers/media)
> Acked-by: Hans de Goede <hdegoede@redhat•com> (For drivers/platform)
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin•com>
> Acked-By: Vinod Koul <vkoul@kernel•org>
> Acked-by: Juergen Gross <jgross@suse•com> (For Xen)
> Acked-by: Lee Jones <lee.jones@linaro•org> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <jth@kernel•org> (For drivers/mcb)
> Acked-by: Johan Hovold <johan@kernel•org>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro•org> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <kwankhede@nvidia•com> (For drivers/vfio)
> Acked-by: Maximilian Luz <luzmaximilian@gmail•com>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux•intel.com> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia•com> (For ipack)
> Reviewed-by: Tom Rix <trix@redhat•com> (For fpga)
> Acked-by: Geoff Levand <geoff@infradead•org> (For ps3)
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix•de>
> ---
> drivers/base/isa.c | 4 +---
Acked-by: William Breathitt Gray <vilhelm.gray@gmail•com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-06 21:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 15:47 [PATCH v2 0/4] bus: Make remove callback return void Uwe Kleine-König
2021-07-06 15:48 ` [PATCH v2 4/4] " Uwe Kleine-König
2021-07-06 16:09 ` Cornelia Huck
2021-07-06 16:44 ` Rafael J. Wysocki
2021-07-06 18:08 ` Bjorn Andersson
2021-07-06 18:43 ` Uwe Kleine-König
2021-07-06 20:43 ` Bjorn Andersson
2021-07-06 18:15 ` Srinivas Pandruvada
2021-07-06 18:32 ` Uwe Kleine-König
2021-07-06 18:51 ` Dan Williams
2021-07-06 21:37 ` William Breathitt Gray [this message]
2021-07-07 14:24 ` Benjamin Tissoires
2021-07-07 21:51 ` Thorsten Scherer
2021-07-08 12:41 ` Ulf Hansson
2021-07-15 13:02 ` Thomas Bogendoerfer
2021-07-08 2:08 ` [PATCH v2 0/4] " Sven Van Asbroeck
2021-07-08 5:38 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOTMp88HfFiy6+RM@shinobu \
--to=vilhelm.gray@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=greybus-dev@lists$(echo .)linaro.org \
--cc=industrypack-devel@lists$(echo .)sourceforge.net \
--cc=kernel@pengutronix$(echo .)de \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-cxl@vger$(echo .)kernel.org \
--cc=linux-fpga@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-i3c@lists$(echo .)infradead.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-ntb@googlegroups$(echo .)com \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-remoteproc@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux1394-devel@lists$(echo .)sourceforge.net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nvdimm@lists$(echo .)linux.dev \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox