Subject: Re: [PATCH net 1/4] sctp: validate from_addr_param return

From: Ben Hutchings <[email-masked]>
Date: Tue, 27 Jul 2021 04:20:22 +0200

On Mon, Jun 28, 2021 at 04:13:41PM -0300, Marcelo Ricardo Leitner wrote:
[...]
> @@ -1174,7 +1175,8 @@ static struct sctp_association *__sctp_rcv_asconf_lookup(
>  	if (unlikely(!af))
>  		return NULL;
>  
> -	af->from_addr_param(&paddr, param, peer_port, 0);
> +	if (af->from_addr_param(&paddr, param, peer_port, 0))
> +		return NULL;
>  
>  	return __sctp_lookup_association(net, laddr, &paddr, transportp);
>  }
[...]

This condition needs to be inverted, doesn't it?

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.