From: Andrew Lunn <andrew@lunn•ch>
To: Ruud Bos <ruud.bos@hbkworld•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"kuba@kernel•org" <kuba@kernel•org>,
"jesse.brandeburg@intel•com" <jesse.brandeburg@intel•com>,
"anthony.l.nguyen@intel•com" <anthony.l.nguyen@intel•com>,
Richard Cochran <richardcochran@gmail•com>
Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS PTP pin functions on 82580/i354/i350
Date: Mon, 19 Jul 2021 17:01:11 +0200 [thread overview]
Message-ID: <YPWTt8h1HFfMbMuh@lunn.ch> (raw)
In-Reply-To: <AM0PR09MB42766646ADEF80E5C54D7EA8F0E19@AM0PR09MB4276.eurprd09.prod.outlook.com>
On Mon, Jul 19, 2021 at 02:45:06PM +0000, Ruud Bos wrote:
> > From: Andrew Lunn <andrew@lunn•ch>
> > Sent: Monday, July 19, 2021 16:29
> > To: Ruud Bos <ruud.bos@hbkworld•com>
> > Cc: netdev@vger•kernel.org; davem@davemloft•net; kuba@kernel•org;
> > jesse.brandeburg@intel•com; anthony.l.nguyen@intel•com; Richard Cochran
> > <richardcochran@gmail•com>
> > Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS
> > PTP pin functions on 82580/i354/i350
> >
> > On Mon, Jul 19, 2021 at 11:33:11AM +0000, Ruud Bos wrote:
> > > The igb driver provides support for PEROUT and EXTTS pin functions that
> > > allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we
> > > are using the PEROUT function to feed a PTP corrected 1pps signal into an
> > > FPGA as cross system synchronized time source.
> >
> > Please always Cc: The PTP maintainer for PTP patches.
> > Richard Cochran <richardcochran@gmail•com>
>
> Thanks, will do that!
> Do I need to resend again?
It is probably a good idea to resend. It will make it easier for
Richard if the patches are in his mailbox.
> This is my first ever contribution, so it's all kinda new to me,
> sorry :-)
Cc: Richard is not so obvious as it should be, since
./scripts/get_maintainers.pl would not of suggested it, since you are
not modify the PTP core. It takes a bit of experience to know this.
This is the second time something like this has happened recently for
Intel Ethernet drivers. The other case was making use of the LED
subsystem from within an Ethernet driver, and the LED subsystem
maintainers were not Cc:. It would be good if the Intel Maintainers
actually took notice of this, they have the experience to know better.
I noticed your patches are not threaded. Did you use git send-email?
It normally does thread a patchset. The threading keeps the patchset
together, which can be important for some of the bots which scoop up
patches in emails and run tests on them. Please see if you can fix
that in the resend.
Andrew
next prev parent reply other threads:[~2021-07-19 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 11:33 [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS PTP pin functions on 82580/i354/i350 Ruud Bos
2021-07-19 14:28 ` Andrew Lunn
2021-07-19 14:45 ` Ruud Bos
2021-07-19 15:01 ` Andrew Lunn [this message]
2021-07-19 17:10 ` Richard Cochran
2021-07-19 17:11 ` Richard Cochran
2021-07-20 10:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPWTt8h1HFfMbMuh@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=ruud.bos@hbkworld$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox